| commit | 72a3fd32a3e0cf7fd6c6ce5f7fb929098424e931 | [log] [tgz] |
|---|---|---|
| author | cherrie-k <80851202+cherrie-k@users.noreply.github.com> | Fri Sep 20 14:55:57 2024 +0900 |
| committer | GitHub <noreply@github.com> | Fri Sep 20 13:55:57 2024 +0800 |
| tree | be65ff6f3d62e63bf3c495bb508c7f5b5475324d | |
| parent | 8720c46f360fd157d99a9d6394f182abd198ed28 [diff] |
[ZEPPELIN-6054] Eliminate no-invalid-this warnings ### What is this PR for? This PR aims to refactor several parts of the Zeppelin project codebase to eliminate no-invalid-this warnings reported by ESLint. These warnings indicate that the this keyword is being used in ways that might lead to unexpected behavior or bugs, particularly within nested callbacks or when this loses its intended context. By addressing these warnings, we improve the stability, readability, and maintainability of the codebase. **Note on `note-action.service.js`**: Initially, I aimed to refactor `note-action.service.js` to eliminate ESLint warnings. However, during testing, it was found that the note actions on the default page were not displaying correctly after the changes. To ensure the stability of the project, I have reverted the changes made to `note-action.service.js`. I plan to revisit this refactor to address the ESLint warnings while ensuring no issues arise in the build process. ### What type of PR is it? Refactoring ### Todos * [x] - Resolve ESLint warnings of files in zeppelin-web/src/app * [ ] - Resolve ESLint warnings of files in zeppelin-web/src/components * [x] - Check if project compiles successfully ### What is the Jira issue? [ZEPPELIN-6054](https://issues.apache.org/jira/browse/ZEPPELIN-6054) ### How should this be tested? * CI * Build and run ### Screenshots (if appropriate) *Current Warnings*: <img width="1102" alt="image" src="https://github.com/user-attachments/assets/4a928656-ec97-4553-a12c-2cd0fbd46350"> ### Questions: * Does the license files need to update? - No * Is there breaking changes for older versions? - No * Does this needs documentation? - No Closes #4788 from cherrie-k/fix/minor-warnings. Signed-off-by: Cheng Pan <chengpan@apache.org>
Documentation: User Guide
Mailing Lists: User and Dev mailing list
Continuous Integration:
Contributing: Contribution Guide
Issue Tracker: Jira
License: Apache 2.0
Zeppelin, a web-based notebook that enables interactive data analytics. You can make beautiful data-driven, interactive and collaborative documents with SQL, Scala and more.
Core features:
To know more about Zeppelin, visit our web site https://zeppelin.apache.org
Please go to install to install Apache Zeppelin from binary package.
Please check Build from source to build Zeppelin from source.