tree 834bef57954e08b199c81d7a65464d21fac38dd8
parent f3bd7ccb63fc10858bb28efca6dbba5752758284
author Henry Zongaro <zongaro@apache.org> 1259186109 +0000
committer Henry Zongaro <zongaro@apache.org> 1259186109 +0000

Applying patch contributed by Martin von Gagern for XALANJ-2493 and XALANJ-2424.

Quoting from Martin, "The current implementation of nodeList2Iterator is
broken, because it can not deal with attribute nodes. It relies on copyNodes
which in turn tries to add attribute nodes as children of some top level node.
Attributes don't live on the children axis, though, so this is against DOM and
causes a DOM exception in the Xerces DOM implementation and probably most other
implementations. The resulting HIERARCHY_REQUEST_ERR was noted e.g. in
XALANJ-2424.  Furthermore, the implementation is inefficient, because it
manually copies each and every node from the source document to a new DTM to
some new DTM....

I dropped copyNodes in favor of Document.importNode, to avoid code duplication
and rely on supposedly more heavily tested code. I also added another level of
elements, so that there is one such dummy node for every item of the source
list, with always a single child or element. A few assertions help ensure this
single child policy. This is especially important in the new implementation,
because otherwise it would become difficult to get the proxied nodes and the
newly DTMified nodes into correct order.