commit 06c8024333a814b88e227cd098193d7e322645aa
author xianjingfeng <xianjingfeng666@gmail.com> Fri Jun 09 22:26:44 2023 +0800
committer GitHub <noreply@github.com> Fri Jun 09 22:26:44 2023 +0800
tree b448cca099dcca38f11650c09f26cb34f687bad8
parent 133912133687a7f9be10d195fa0c08c4a41607fb

[#933][0.7] fix: incorrect metric grpc_server_connection_number (#941)

### What changes were proposed in this pull request?

Fix incorrect metric grpc_server_connection_number

### Why are the changes needed?

Fix: #933 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UT

common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java

diff --git a/common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java b/common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java
index 2c29dd2..ef687ec 100644
--- a/common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java
+++ b/common/src/main/java/org/apache/uniffle/common/rpc/MonitoringServerTransportFilter.java
@@ -37,7 +37,9 @@
   }
 
   public void transportTerminated(Attributes transportAttrs) {
-    grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY);
+    if (transportAttrs != null) {
+      grpcMetrics.decGauge(GRPC_SERVER_CONNECTION_NUMBER_KEY);
+    }
     super.transportTerminated(transportAttrs);
   }
 }