commit f792cd70ef87ccefb6acff3ef12a375f11a8e6b9
author Brian Neradt <brian.neradt@gmail.com> Wed Sep 17 14:27:58 2025 -0500
committer GitHub <noreply@github.com> Wed Sep 17 14:27:58 2025 -0500
tree 069af0cd7158ae51b692768501f23a980c6f96bb
parent 2128398aa01cc624da4acbe1a3153cc5da35cfb8

header_rewrite: Fix uninitialized bufp/hdr_loc (#12520)

Fix a bug where if RSRC_RESPONSE_STATUS is requested without
RSRC_SERVER_RESPONSE_HEADERS, the bufp and hdr_loc variables would be
uninitialized when passed to TSHttpHdrStatusGet().

This change ensures that TSHttpTxnServerRespGet() is called when
either resource is requested, properly initializing the required
variables.

plugins/header_rewrite/resources.cc

diff --git a/plugins/header_rewrite/resources.cc b/plugins/header_rewrite/resources.cc
index 1179706..7f5a755 100644
--- a/plugins/header_rewrite/resources.cc
+++ b/plugins/header_rewrite/resources.cc
@@ -52,16 +52,16 @@
   switch (hook) {
   case TS_HTTP_READ_RESPONSE_HDR_HOOK:
     // Read response headers from server
-    if (ids & RSRC_SERVER_RESPONSE_HEADERS) {
+    if ((ids & RSRC_SERVER_RESPONSE_HEADERS) || (ids & RSRC_RESPONSE_STATUS)) {
       Dbg(pi_dbg_ctl, "\tAdding TXN server response header buffers");
       if (TSHttpTxnServerRespGet(state.txnp, &bufp, &hdr_loc) != TS_SUCCESS) {
         Dbg(pi_dbg_ctl, "could not gather bufp/hdr_loc for response");
         return;
       }
-    }
-    if (ids & RSRC_RESPONSE_STATUS) {
-      Dbg(pi_dbg_ctl, "\tAdding TXN server response status resource");
-      resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
+      if (ids & RSRC_RESPONSE_STATUS) {
+        Dbg(pi_dbg_ctl, "\tAdding TXN server response status resource");
+        resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
+      }
     }
     break;