commit 957f37ed36c0b58f9e99f7db806dc3969f9f46ca
author Mark Thomas <markt@apache.org> Wed Jul 05 17:34:03 2023 +0100
committer Mark Thomas <markt@apache.org> Wed Jul 05 17:35:30 2023 +0100
tree 2dec47f6dde8b04a8e91d08d1e382f7e5c66f62e
parent 32e79883d075e239a836d3506932b643e4c9f054

Remove unnecessary code

Dead code identified by Coverity Scan

java/org/apache/coyote/http2/StreamProcessor.java

diff --git a/java/org/apache/coyote/http2/StreamProcessor.java b/java/org/apache/coyote/http2/StreamProcessor.java
index f9dfefc..80c04ed 100644
--- a/java/org/apache/coyote/http2/StreamProcessor.java
+++ b/java/org/apache/coyote/http2/StreamProcessor.java
@@ -466,17 +466,12 @@
         }
 
         // HTTP header names must be tokens.
+        // Stream#emitHeader() checks that all the pseudo headers appear first.
         MimeHeaders headers = request.getMimeHeaders();
-        boolean previousHeaderWasPseudoHeader = true;
         Enumeration<String> names = headers.names();
         while (names.hasMoreElements()) {
             String name = names.nextElement();
-            if (H2_PSEUDO_HEADERS_REQUEST.contains(name)) {
-                if (!previousHeaderWasPseudoHeader) {
-                    return false;
-                }
-            } else if (!HttpParser.isToken(name)) {
-                previousHeaderWasPseudoHeader = false;
+            if (!H2_PSEUDO_HEADERS_REQUEST.contains(name) && !HttpParser.isToken(name)) {
                 return false;
             }
         }