TINKERPOP-2847 Compare and store request UUIDs as lower case strings in gremlin-javascript.
Storing and comparing the request IDs in lower case prevents issues that
arise when the supplied ID and returned ID are using different cases to
represent the hex values of the UUID.
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index c62bea6..82dc0ff 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -60,6 +60,7 @@
* Prevented fast `NoHostAvailableException` in favor of more direct exceptions when borrowing connections from the `ConnectionPool`.
* Fixed an issue in Go and Python GLVs where modifying per request settings to override request_id's was not working correctly.
* Fixed incorrect implementation for `GraphTraversalSource.With` in `gremlin-go`.
+* Fixed a case sensitivity issue when comparing request UUIDs in `gremlin-javascript`.
==== Bugs
diff --git a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
index acaeab4..39bca7c 100644
--- a/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
+++ b/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
@@ -83,7 +83,7 @@
*/
this.mimeType = options.mimeType || defaultMimeType;
- // A map containing the request id and the handler
+ // A map containing the request id and the handler. The id should be in lower case to prevent string comparison issues.
this._responseHandlers = {};
this._reader = options.reader || this._getDefaultReader(this.mimeType);
this._writer = options.writer || this._getDefaultWriter(this.mimeType);
@@ -173,7 +173,8 @@
/** @override */
submit(processor, op, args, requestId) {
- const rid = requestId || utils.getUuid();
+ // TINKERPOP-2847: Use lower case to prevent string comparison issues.
+ const rid = (requestId || utils.getUuid()).toLowerCase();
return this.open().then(
() =>
new Promise((resolve, reject) => {
@@ -201,7 +202,8 @@
/** @override */
stream(processor, op, args, requestId) {
- const rid = requestId || utils.getUuid();
+ // TINKERPOP-2847: Use lower case to prevent string comparison issues.
+ const rid = (requestId || utils.getUuid()).toLowerCase();
const readableStream = new Stream.Readable({
objectMode: true,
@@ -315,6 +317,8 @@
return;
}
+ // TINKERPOP-2847: Use lower case to prevent string comparison issues.
+ response.requestId = response.requestId.toLowerCase();
const handler = this._responseHandlers[response.requestId];
if (!handler) {
