tree 69efd7065e81348fd22f8fbc07ec475846e8a111
parent dda80547b10d698784713eb62a04f6f42eae107b
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1607640157 -0800
committer Yuxuan 'fishy' Wang <fishywang@gmail.com> 1608139878 -0800

THRIFT-5322: Guard against large string/binary lengths in Go

Client: go

In TBinaryProtocol.ReadString, TBinaryProtocol.ReadBinary,
TCompactProtocol.ReadString, and TCompactProtocol.ReadBinary, use
safeReadBytes to prevent from large allocation on malformed sizes.

    $ go test -bench=SafeReadBytes -benchmem
    BenchmarkSafeReadBytes/normal-12                  625057              1789 ns/op            2176 B/op          5 allocs/op
    BenchmarkSafeReadBytes/max-askedSize-12           545271              2236 ns/op           14464 B/op          7 allocs/op
    PASS