Google Git
Sign in
apache / superset / refs/heads/fix-app-root-oauth
commit2ce3b10b8ba6740c32a051e4d6d3bb93a289be35[log] [tgz]
authorJoe Li <joe@preset.io>Tue Sep 30 09:28:21 2025 -0700
committerJoe Li <joe@preset.io>Tue Sep 30 09:28:21 2025 -0700
tree5b3a6c0ce9f199a62d0b59fc8de70af7006c30e5
parent0e3385b9e7f9327e3360a1e8e86125d89feb907b [diff]
test(auth): add comprehensive test coverage for OAuth/LDAP APP_ROOT fix

Significantly improved test quality from 6/10 to 9/10 by adding comprehensive test coverage:

✅ Critical Improvements:
- Fixed SupersetClient mock issue using jest.spyOn() pattern
- Enabled critical regression test that verifies no double-prefixing occurs
- Added full APP_ROOT test coverage for Register component

📊 Test Statistics:
- Login tests: increased from 8 to 28 tests (250% increase)
- Register tests: increased from 3 to 7 tests (133% increase)
- Total: 35 comprehensive tests (218% increase from 11)

🧪 New Test Categories Added:

1. Edge Cases:
   - Empty providers array handling
   - Invalid provider objects (null names, missing icons)
   - Special characters in provider names
   - Very long provider names
   - Mixed auth types
   - Null/undefined configurations

2. Integration Tests:
   - Full login flow with session storage verification
   - Loading state during form submission
   - Form validation (required fields)
   - Password visibility toggle
   - Form reset on navigation

3. User Interaction Tests:
   - Keyboard navigation for accessibility
   - Tab order verification
   - Uses @testing-library/user-event for better simulation

4. Error State Tests:
   - Network error handling
   - Malformed bootstrap data
   - Missing sessionStorage handling
   - OAuth providers with malformed URLs
   - Error message display from session storage

This ensures the OAuth/LDAP APP_ROOT fix is thoroughly tested and prevents regressions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2 files changed
tree: 5b3a6c0ce9f199a62d0b59fc8de70af7006c30e5
  1. .claude/
  2. .cursor/
  3. .devcontainer/
  4. .github/
  5. ASF/
  6. CHANGELOG/
  7. docker/
  8. docs/
  9. helm/
  10. RELEASING/
  11. requirements/
  12. RESOURCES/
  13. scripts/
  14. superset/
  15. superset-core/
  16. superset-embedded-sdk/
  17. superset-extensions-cli/
  18. superset-frontend/
  19. superset-websocket/
  20. tests/
  21. CLAUDE.md ⇨ LLMS.md
  22. GEMINI.md ⇨ LLMS.md
  23. GPT.md ⇨ LLMS.md
  24. .asf.yaml
  25. .codecov.yml
  26. .coveragerc
  27. .dockerignore
  28. .editorconfig
  29. .flaskenv
  30. .fossa.yml
  31. .gitattributes
  32. .gitignore
  33. .gitmodules
  34. .markdownlint.json
  35. .pre-commit-config.yaml
  36. .pylintrc
  37. .rat-excludes
  38. CHANGELOG.md
  39. CODE_OF_CONDUCT.md
  40. CONTRIBUTING.md
  41. docker-compose-image-tag.yml
  42. docker-compose-light.yml
  43. docker-compose-non-dev.yml
  44. docker-compose.yml
  45. Dockerfile
  46. dockerize.Dockerfile
  47. INSTALL.md
  48. LICENSE.txt
  49. lintconf.yaml
  50. LLMS.md
  51. Makefile
  52. MANIFEST.in
  53. NOTICE
  54. pyproject.toml
  55. pytest.ini
  56. README.md
  57. setup.py
  58. superset_text.yml
  59. UPDATING.md
README.md

Superset

License Latest Release on Github Build Status PyPI version Coverage Status PyPI Get on Slack Documentation

A modern, enterprise-ready business intelligence web application.

Why Superset? | Supported Databases | Installation and Configuration | Release Notes | Get Involved | Contributor Guide | Resources | Organizations Using Superset

Why Superset?

Superset is a modern data exploration and data visualization platform. Superset can replace or augment proprietary business intelligence tools for many teams. Superset integrates well with a variety of data sources.

Superset provides:

  • A no-code interface for building charts quickly
  • A powerful, web-based SQL Editor for advanced querying
  • A lightweight semantic layer for quickly defining custom dimensions and metrics
  • Out of the box support for nearly any SQL database or data engine
  • A wide array of beautiful visualizations to showcase your data, ranging from simple bar charts to geospatial visualizations
  • Lightweight, configurable caching layer to help ease database load
  • Highly extensible security roles and authentication options
  • An API for programmatic customization
  • A cloud-native architecture designed from the ground up for scale

Screenshots & Gifs

Video Overview

superset-video-1080p.webm

Large Gallery of Visualizations


Craft Beautiful, Dynamic Dashboards


No-Code Chart Builder


Powerful SQL Editor


Supported Databases

Superset can query data from any SQL-speaking datastore or data engine (Presto, Trino, Athena, and more) that has a Python DB-API driver and a SQLAlchemy dialect.

Here are some of the major database solutions that are supported:

A more comprehensive list of supported databases along with the configuration instructions can be found here.

Want to add support for your datastore or data engine? Read more here about the technical requirements.

Installation and Configuration

Try out Superset's quickstart guide or learn about the options for production deployments.

Get Involved

Contributor Guide

Interested in contributing? Check out our CONTRIBUTING.md to find resources around contributing along with a detailed guide on how to set up a development environment.

Resources

  • Superset “In the Wild” - open a PR to add your org to the list!
  • Feature Flags - the status of Superset's Feature Flags.
  • Standard Roles - How RBAC permissions map to roles.
  • Superset Wiki - Tons of additional community resources: best practices, community content and other information.
  • Superset SIPs - The status of Superset's SIPs (Superset Improvement Proposals) for both consensus and implementation status.

Understanding the Superset Points of View

Repo Activity