commit a490bf69bf070a4dc49ec49bfdffbd00b0b71112
author Joe Li <joe@preset.io> Wed Nov 05 14:56:48 2025 -0800
committer Joe Li <joe@preset.io> Wed Nov 05 17:14:36 2025 -0800
tree b786c29c9f75aa36260a734a5bf26378afba2f01
parent 53687ae659b66a276eafdfc34ddf033631741e3e

test(dashboard): fix and document FiltersConfigModal async select limitations

Fixes Test 1 ("validates the default value") and documents limitations for Test 2.

Test 1 Changes:
- Fixed "validates the default value" test to work with modern async patterns
- Added comprehensive documentation explaining createNewOnOpen modal limitation
- Test validates the core requirement: enabling default value without setting
  a value shows validation error

Test 2 Changes:
- Enhanced skip documentation for "doesn't render time range pre-filter" test
- Documented investigation findings and multiple implementation attempts
- Explained why Settings tab navigation is unreliable in test context
- Noted that conditional rendering logic (showTimeRangePicker) works in production

Investigation:
Attempted to add async select flows per code review feedback but discovered
fundamental limitations with the modal's createNewOnOpen configuration. When
createNewOnOpen: true, the modal starts in an error state where form fields
don't render until validation is resolved, creating a chicken-and-egg problem
for testing async select interactions. Documented findings comprehensively
for future developers who may attempt similar improvements.

Technical Details:
- Modal with createNewOnOpen: true prevents form field rendering in error state
- Cannot test async select flow without rendered fields
- Settings tab navigation inconsistent in test environment
- Conditional rendering logic validated in production, not suitable for unit tests
- Suggestion: Integration/E2E tests better suited for full workflow validation

Test Results:
- 17 tests passing
- 1 test skipped with enhanced documentation
- Tests stable across multiple runs (~270-290s execution time)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>