commit c7a0339df9e16df92135fa8cdff26524e506d342
author hughhhh <hughmil3s@gmail.com> Thu Jun 17 19:22:48 2021 -0400
committer hughhhh <hughmil3s@gmail.com> Thu Jun 17 19:22:48 2021 -0400
tree f00701f612c69dcadebbd720fb318900f7a064f6
parent 27efb29bbf2f6f4957e7df929c82552edc787564

reset validation errors onClose

superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
index db2d4ae..e37fcd7 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
@@ -264,7 +264,6 @@
   />
 );
 const displayField = ({
-  required,
   changeMethods,
   getValidation,
   validationErrors,

superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
index 2c9c49d..44a0cf8 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -284,7 +284,11 @@
   >(dbReducer, null);
   const [tabKey, setTabKey] = useState<string>(DEFAULT_TAB_KEY);
   const [availableDbs, getAvailableDbs] = useAvailableDatabases();
-  const [validationErrors, getValidation] = useDatabaseValidation();
+  const [
+    validationErrors,
+    getValidation,
+    setValidationErrors,
+  ] = useDatabaseValidation();
   const [hasConnectedDb, setHasConnectedDb] = useState<boolean>(false);
   const [dbName, setDbName] = useState('');
   const [isLoading, setLoading] = useState<boolean>(false);
@@ -340,6 +344,7 @@
   const onClose = () => {
     setDB({ type: ActionType.reset });
     setHasConnectedDb(false);
+    setValidationErrors(null); // reset validation errors on close
     onHide();
   };
 

superset-frontend/src/views/CRUD/hooks.ts

diff --git a/superset-frontend/src/views/CRUD/hooks.ts b/superset-frontend/src/views/CRUD/hooks.ts
index d229315..3132422 100644
--- a/superset-frontend/src/views/CRUD/hooks.ts
+++ b/superset-frontend/src/views/CRUD/hooks.ts
@@ -687,5 +687,5 @@
     [setValidationErrors],
   );
 
-  return [validationErrors, getValidation] as const;
+  return [validationErrors, getValidation, setValidationErrors] as const;
 }