commit 36bc7b0b8055b7ccdfe06033e418363b41e56c66
author John Bodley <4567245+john-bodley@users.noreply.github.com> Mon Aug 16 10:20:44 2021 -0700
committer GitHub <noreply@github.com> Tue Aug 17 05:20:44 2021 +1200
tree 36f5e73863fbaa2afc14f72730ad58971bcbc371
parent 0df15bf2079e3958b4fb6bc070ec97bb770a6ad3

chore(pylint): Reenable too-few-public-methods check (#16264)

Co-authored-by: John Bodley <john.bodley@airbnb.com>

.pylintrc

diff --git a/.pylintrc b/.pylintrc
index bf97ed2..e921ee5 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -85,7 +85,6 @@
     missing-docstring,
     too-many-lines,
     raise-missing-from,
-    too-few-public-methods,
     duplicate-code,
 
 [REPORTS]

superset/commands/base.py

diff --git a/superset/commands/base.py b/superset/commands/base.py
index 2db12bb..2592a03 100644
--- a/superset/commands/base.py
+++ b/superset/commands/base.py
@@ -43,7 +43,7 @@
         """
 
 
-class CreateMixin:
+class CreateMixin:  # pylint: disable=too-few-public-methods
     @staticmethod
     def populate_owners(
         user: User, owner_ids: Optional[List[int]] = None
@@ -61,7 +61,7 @@
         return populate_owners(user, owner_ids, default_to_user=True)
 
 
-class UpdateMixin:
+class UpdateMixin:  # pylint: disable=too-few-public-methods
     @staticmethod
     def populate_owners(
         user: User, owner_ids: Optional[List[int]] = None

superset/databases/schemas.py

diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py
index 303d740..b0dfc2f 100644
--- a/superset/databases/schemas.py
+++ b/superset/databases/schemas.py
@@ -214,7 +214,7 @@
     return value
 
 
-class DatabaseParametersSchemaMixin:
+class DatabaseParametersSchemaMixin:  # pylint: disable=too-few-public-methods
     """
     Allow SQLAlchemy URI to be passed as separate parameters.
 

superset/extensions.py

diff --git a/superset/extensions.py b/superset/extensions.py
index 619de6a..dafb455 100644
--- a/superset/extensions.py
+++ b/superset/extensions.py
@@ -98,7 +98,7 @@
         return self.manifest.get(bundle, {}).get(asset_type, [])
 
 
-class ProfilingExtension:
+class ProfilingExtension:  # pylint: disable=too-few-public-methods
     def __init__(self, interval: float = 1e-4) -> None:
         self.interval = interval
 

superset/utils/encrypt.py

diff --git a/superset/utils/encrypt.py b/superset/utils/encrypt.py
index 10bc97d..240ca5a 100644
--- a/superset/utils/encrypt.py
+++ b/superset/utils/encrypt.py
@@ -22,7 +22,7 @@
 from sqlalchemy_utils import EncryptedType
 
 
-class AbstractEncryptedFieldAdapter(ABC):
+class AbstractEncryptedFieldAdapter(ABC):  # pylint: disable=too-few-public-methods
     @abstractmethod
     def create(
         self,
@@ -33,7 +33,9 @@
         pass
 
 
-class SQLAlchemyUtilsAdapter(AbstractEncryptedFieldAdapter):
+class SQLAlchemyUtilsAdapter(  # pylint: disable=too-few-public-methods
+    AbstractEncryptedFieldAdapter
+):
     def create(
         self,
         app_config: Optional[Dict[str, Any]],

superset/utils/profiler.py

diff --git a/superset/utils/profiler.py b/superset/utils/profiler.py
index 087ec60..269cf5c 100644
--- a/superset/utils/profiler.py
+++ b/superset/utils/profiler.py
@@ -27,7 +27,7 @@
     Profiler = None
 
 
-class SupersetProfiler:
+class SupersetProfiler:  # pylint: disable=too-few-public-methods
     """
     WSGI middleware to instrument Superset.