On the 'multi-wc-format' branch: fix and clarify use of default WC version.

Fix up some places where we were still using the latest version and should
be using the default version.

Introduce an explicit definition 'SVN_WC__DEFAULT_VERSION' and use it where
this is the intended meaning.

Move the defaulting down a layer, into 'svn_wc__format_from_version', except
where the client layer needs to care or do something different.

* subversion/include/private/svn_wc_private.h,
  subversion/libsvn_wc/upgrade.c,
  subversion/libsvn_wc/wc_db_wcroot.c
  (svn_wc__format_from_version,
   svn_wc__format_from_context): Use default version rather than latest.

* subversion/libsvn_client/checkout.c
  (svn_client__checkout_internal): Add a comment.

* subversion/libsvn_client/upgrade.c
  (svn_client_upgrade2): Don't handle the defaulting here; let
    'svn_wc__format_from_version' handle it.

* subversion/libsvn_wc/deprecated.c
  (svn_wc_ensure_adm4,
   svn_wc_upgrade): Use default version rather than latest.

* subversion/libsvn_wc/wc.h
  (SVN_WC__DEFAULT_VERSION): New.

* subversion/tests/libsvn_wc/entries-compat.c
  (test_access_baton_like_locking): Don't handle the defaulting here; let
    'svn_wc__format_from_version' handle it.

* subversion/tests/libsvn_wc/utils.c
  (svn_test__create_fake_wc): Don't handle the defaulting here; let
    'svn_wc__format_from_version' handle it.

* subversion/tests/libsvn_wc/wc-queries-test.c
  (create_memory_db): Don't handle the defaulting here; let
    'svn_wc__format_from_version' handle it.


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/multi-wc-format@1897967 13f79535-47bb-0310-9956-ffa450edef68
11 files changed