This patch fixes some problems with the second in a series of fs-refactoring patches now called pluggable-db.  The concerns driving this patch can be found in the following thread: http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=86869

NOTE: The next installment of the pluggable-db (db_cntxt) is being delayed until      some design documentation is updated.  The old documents are being 
      reformatted and will be placed in the notes directory of this branch.  
      This will make it easier to follow any design changes that occur going
      forward.

* subversion/libsvn_fs/bdb/txn-table.c
  Removed include of bdb-fs.h.
  
* subversion/libsvn_fs/bdb/reps-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/nodes-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/copies-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/uuids-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/strings-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/changes-table.c
  Removed include of bdb-fs.h.

* subversion/libsvn_fs/bdb/nodes-table.h
    (svn_fs__bdb_open_nodes_table) declaration was put back.

* subversion/libsvn_fs/bdb/changes-table.h
    (svn_fs__bdb_open_changes_table) declaration was put back.

* subversion/libsvn_fs/bdb/reps-table.h
    (svn_fs__bdb_open_reps_table) declaration was put back.

* subversion/libsvn_fs/bdb/txn-table.h
    (svn_fs__bdb_open_transactions_table) declaration was put back.

* subversion/libsvn_fs/bdb/copies-table.h
    (svn_fs__bdb_open_copies_table) declaration was put back.

* subversion/libsvn_fs/bdb/uuids-table.h
    (svn_fs__bdb_open_uuids_table) declaration was put back.

* subversion/libsvn_fs/bdb/strings-table.h
    (svn_fs__bdb_open_strings_table) declaration was put back.

* subversion/libsvn_fs/bdb/rev-table.h
    (svn_fs__bdb_open_revisions_table) declaration was put back.

* subversion/libsvn_fs/bdb/bdb-fs.h
  Renamed temporary public declarations to follow svn namespace standards:
    (svn_fs__bdb_cleanup_fs_apr) was (bdb_cleanup_fs_apr.
    (svn_fs__bdb_create_fs) was (bdb_create_fs).
    (svn_fs__bdb_open_fs) was (bdb_open_fs).
    (svn_fs__bdb_recover_fs) was (bdb_recover_fs).
    (svn_fs__bdb_delete_fs) was (bdb_delete_fs).
    (svn_fs__bdb_set_berkeley_errcall) was (bdb_set_berkeley_errcall).
  Removed the following declarations for table open functions:
    (svn_fs__bdb_open_changes_table)
    (svn_fs__bdb_open_copies_table)
    (svn_fs__bdb_open_nodes_table)
    (svn_fs__bdb_open_reps_table)
    (svn_fs__bdb_open_revisions_table)
    (svn_fs__bdb_open_strings_table)
    (svn_fs__bdb_open_transactions_table)
    (svn_fs__bdb_open_uuids_table)

* subversion/libsvn_fs/bdb/bdb-fs.c
  Renamed function names to follow svn namespace standards:
    (svn_fs__bdb_cleanup_fs_apr) was (bdb_cleanup_fs_apr.
    (svn_fs__bdb_create_fs) was (bdb_create_fs).
    (svn_fs__bdb_open_fs) was (bdb_open_fs).
    (svn_fs__bdb_recover_fs) was (bdb_recover_fs).
    (svn_fs__bdb_delete_fs) was (bdb_delete_fs).
    (svn_fs__bdb_set_berkeley_errcall) was (bdb_set_berkeley_errcall).
  Replaced svn_utf_cstring_from_utf8 with svn_path_cstring_from_utf8 
    to restore a change that was undone. (svn_fs__bdb_create_fs)
  Removed a cast that was removed in an earlier patch. 
    (svn_fs__bdb_cleanup_fs_apr)
  Fixed a couple formatting issues introduced by the 5212.

* subversion/libsvn_fs/fs.c
    Call renamed functions in bdb-fs.c by name until vtable installed:
    (svn_fs__bdb_cleanup_fs_apr) was (bdb_cleanup_fs_apr.
    (svn_fs__bdb_create_fs) was (bdb_create_fs).
    (svn_fs__bdb_open_fs) was (bdb_open_fs).
    (svn_fs__bdb_recover_fs) was (bdb_recover_fs).
    (svn_fs__bdb_delete_fs) was (bdb_delete_fs).
    (svn_fs__bdb_set_berkeley_errcall) was (bdb_set_berkeley_errcall).


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/pluggable-db@845347 13f79535-47bb-0310-9956-ffa450edef68