Official Solr Dockerfile Management
In general most interactions with this repository should be done via the Solr Release Wizard, not manually.
How an Official Solr Dockerfile is released
- In the Solr Release Wizard, an official Dockerfile will be created as a part of the release candidate. The official Dockerfile is tested as a part of the release candidate.
- But importantly, the official Dockerfile is not voted on because small changes may be requested by the Official Images team. We need to be able to make changes for these requests after a vote succeeds.
- If the vote succeeds:
- As a part of the artifact-uploading steps, the Release Wizard will clone this repo (
- It will then add the successfully voted on
Dockerfile to the respective folder for the released version (
- If it is a patch release, the existing
Dockerfile for that version will be over-written.
- It will commit this
Dockerfile, and push to the
main branch of this repo. No PR or reviews required.
- Now that this repo has the new
Dockerfile committed to main, the Github Actions Workflow will kick-off.
- It will use
generate-stackbrew-library.sh to build the Solr metadata for the latest
main branch commit.
- After generating a new version of this file, it will create a PR in docker-library/official-images to update the official image.
- This PR will have to be reviewed and merged by the Docker Official Images team before the release will be available.
- If a change to the Dockerfile/metadata is required by the maintainers, make further PRs/commits to this repo. Refer to the section on making fixes for an open PR for more information.
- Before the PR can be approved, one of the listed Solr maintainers must comment their approval of the PR.
- The Official Docker image should now be available
How does the automated PR work?
The Github Actions Workflow is triggered on commits to the
main branch that touch the following files:
The PR in docker-library/official-images is generated through:
- Creating a branch in the docker-solr/official-images.
- We have to use this repo, because Apache does not allow forks in their organization.
- This commit is made by the @docker-solr-builder, which has credentials saved in this repo.
- These credentials were added by emailing them to the Apache infra-team (
- If you need access to this account or credentials, reach out to the private mailing list.
- Once the commit and branch are created, the Github Action will create a PR in the official repo.
Make fixes for an open automated PR
If the PR in docker-library/official-images is already created & open, any commit you make to this repo will auto-update the existing PR. The commit has to change the files that the Github Actions Workflow is listening on, which are listed above.
The PR name will change to reflect the most recent commit message, and the pr description will link to this commit instead. The PR contents will be updated to reflect the generated solr image metadata made from the latest commit. There is no need to close an existing PR to make further changes.
Make sure that all changes to Dockerfiles are reflected in the official source of these dockerfiles, apache/solr. This will ensure that the official-images team does not ask for the same changes in future releases. This speeds up the release process and ensures that the Dockerfile provided in the binary-release is as similar as possible to the official Solr Dockerfile.