Google Git
Sign in
apache/sling-org-apache-sling-engine/refs/heads/master
commit
75724dd4a5b00be1462cda6e4f2d062652d2639a
[log]
author
Julian Sedding <jsedding@apache.org>
Wed Jun 24 16:36:52 2026 +0200
committer
GitHub <noreply@github.com>
Wed Jun 24 16:36:52 2026 +0200
tree
145b463547e2784b65273c37cbfcf4d14e0bbd3c
parent
047d5c1ce95edb8ce40ef9a64859d08ea5c4c9cb [diff]
SLING-13251 - MBean registration in ServletFilterManager fails for factory components (#80)

- prefer service.pid over component.name, as the former
  is unique (if present), whereas the latter is not unique
- quote filter name before including it in the JMX ObjectName
- add test coverage for JMX MBean registration
- extract method for DRYer code (and higher coverage)
6 files changed
tree: 145b463547e2784b65273c37cbfcf4d14e0bbd3c
  1. src/
  2. .asf.yaml
  3. .git-blame-ignore-revs
  4. .gitignore
  5. .sling-module.json
  6. AGENTS.md
  7. bnd.bnd
  8. CLAUDE.md
  9. CODE_OF_CONDUCT.md
  10. CONTRIBUTING.md
  11. Jenkinsfile
  12. LICENSE
  13. pom.xml
  14. README.md
README.md

Apache Sling

Build Status Test Status Coverage Sonarcloud Status JavaDoc Maven Central License

Apache Sling Engine Implementation

This module is part of the Apache Sling project and implements the core Sling request processing pipeline.

Overview

org.apache.sling.engine provides the Sling engine bundle that:

  • registers the main servlet via OSGi HTTP Whiteboard
  • resolves resources and dispatches requests
  • manages Sling filter chains and request/response wrapping
  • exposes request processor and filter processor metrics via JMX
  • supports both javax.servlet (legacy) and jakarta.servlet through adapter classes

Requirements

  • Java 17
  • Maven

Build and test

# Build and package (skip tests)
mvn clean install -DskipTests

# Full build with tests
mvn clean install

# Run all tests
mvn test

# Run a single test class
mvn test -Dtest=SlingRequestPathInfoTest

# Run tests with a name pattern
mvn test -Dtest="*FilterChain*"

# License header check (Apache RAT)
mvn apache-rat:check

# Check formatting (Spotless, inherited from parent POM)
mvn spotless:check

# Apply formatting
mvn spotless:apply

# Run Japex microbenchmarks
mvn test -Pbenchmarks

Repository layout

pom.xml                          Maven build descriptor
bnd.bnd                          OSGi bundle manifest instructions
src/
  main/java/org/apache/sling/engine/
    *.java                       Public API
    impl/                        Internal implementation
      adapter/                   javax <-> jakarta servlet adapters
      console/                   Web Console plugins
      debug/                     RequestProgressTracker integration
      filter/                    Sling filter chain management
      helper/                    Servlet context/request listener helpers
      log/                       Request logging support
      parameters/                Request parameter and multipart handling
      request/                   Request data and dispatching
    jmx/                         JMX MBean interfaces
    servlets/                    Error handler servlet API
  test/java/                     Unit tests
  test/resources/japex/          Benchmark configurations

Notes

  • OSGi Declarative Services annotations are used (org.osgi.service.component.annotations).
  • The bundle imports javax.servlet with a compatibility range and supports Jakarta Servlet API in parallel.