| commit | d783f8461eb792a83070a6aef213e1237ca177db | [log] [tgz] |
|---|---|---|
| author | Robert Munteanu <rombert@apache.org> | Fri Jun 07 11:33:04 2019 +0200 |
| committer | Robert Munteanu <robert.munteanu@gmail.com> | Wed Jun 12 16:27:19 2019 +0200 |
| tree | 7ec3a1c48676b4dfb7d965893a656aaabb0b3f31 | |
| parent | 0b3cb1ec6db4c6e878f440a9a3f3aee54fa178e3 [diff] |
Implement default timeouts for httpclient 4.x
This module is part of the Apache Sling project.
This module provides a java agent that uses the instrumentation API to add timeouts to connect calls made via HTTP or HTTPs without setting read and connect timeouts. It is intended as an additional layer of control to use when running unstrusted client code that may make calls without explicitly setting timeouts.
Build the project with mvn clean package and then run a simple connection test with
java -javaagent:target/url-connection-agent-0.0.1-SNAPSHOT-jar-with-dependencies.jar=<connect-timeout>,<read-timeout> -cp target/test-classes:target/it-dependencies/* org.apache.sling.uca.impl.Main <url> <client-type>
The parameters are as follows:
<connect-timeout> - connection timeout in milliseconds<read-timeout>- read timeout in milliseconds<url> - the URL to access<client-type> - the client type, either JavaNet for java.net.URL-based connections ,HC3 for Apache Commons HttpClient 3.x or HC4 for Apache Commons HttpClient 4.xFor a test that always fails, set one of the timeouts to 1. Both executions listed below will typically fail:
java -javaagent:target/url-connection-agent-0.0.1-SNAPSHOT-jar-with-dependencies.jar=1,1000 -cp target/test-classes:target/it-dependencies/* org.apache.sling.uca.impl.Main https://sling.apache.org JavaNet java -javaagent:target/url-connection-agent-0.0.1-SNAPSHOT-jar-with-dependencies.jar=1000,1 -cp target/test-classes:target/it-dependencies/* org.apache.sling.uca.impl.Main https://sling.apache.org JavaNet
In contrast, the execution below should succeed:
java -javaagent:target/url-connection-agent-0.0.1-SNAPSHOT-jar-with-dependencies.jar=1000,1000 -cp target/test-classes:target/it-dependencies/* org.apache.sling.uca.impl.Main https://sling.apache.org JavaNet