Following this checklist to help us incorporate your contribution quickly and easily:
[SHIRO-XXX] - Fixes bug in SessionManager, where you replace
SHIRO-XXXwith the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
git rebase -i.
Trivial changes like typos do not require a JIRA issue (javadoc, comments...). In this case, just format the pull request title like
(DOC) - Add javadoc in SessionManager.
If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.