commit d012d4a1c7a247aef9bde469db1518b458ea0b86
author Sean Mullan <mullan@apache.org> Thu Jun 18 13:07:38 2015 +0000
committer Sean Mullan <mullan@apache.org> Thu Jun 18 13:07:38 2015 +0000
tree d43ea8dd1a15f568eb18b5261ffaf097c70beaec
parent 84927c867108fe1afa3fbae4313c5ae690697ba9

Wraps calls to System.getProperty in doPrivileged.


git-svn-id: https://svn.apache.org/repos/asf/santuario/xml-security-java/branches/1.5.x-fixes@1686210 13f79535-47bb-0310-9956-ffa450edef68

src/main/java/org/apache/xml/security/utils/IgnoreAllErrorHandler.java

diff --git a/src/main/java/org/apache/xml/security/utils/IgnoreAllErrorHandler.java b/src/main/java/org/apache/xml/security/utils/IgnoreAllErrorHandler.java
index f4d168e..c4bdd65 100644
--- a/src/main/java/org/apache/xml/security/utils/IgnoreAllErrorHandler.java
+++ b/src/main/java/org/apache/xml/security/utils/IgnoreAllErrorHandler.java
@@ -31,19 +31,30 @@
 public class IgnoreAllErrorHandler implements ErrorHandler {
 
     /** {@link org.apache.commons.logging} logging facility */
-    private static org.apache.commons.logging.Log log =
+    private static final org.apache.commons.logging.Log log =
         org.apache.commons.logging.LogFactory.getLog(IgnoreAllErrorHandler.class);
 
     /** Field throwExceptions */
     private static final boolean warnOnExceptions =
-        System.getProperty("org.apache.xml.security.test.warn.on.exceptions", "false").equals("true");
+        getProperty("org.apache.xml.security.test.warn.on.exceptions");
 
     /** Field throwExceptions           */
     private static final boolean throwExceptions = 
-        System.getProperty("org.apache.xml.security.test.throw.exceptions", "false").equals("true");
+        getProperty("org.apache.xml.security.test.throw.exceptions");
 
+    private static boolean getProperty(final String name) {
+        return java.security.AccessController.doPrivileged(
+                new java.security.PrivilegedAction<Boolean>() {
+
+                    @Override
+                    public Boolean run() {
+                        return Boolean.getBoolean(name);
+                    }
+                });
+    }
 
     /** @inheritDoc */
+    @Override
     public void warning(SAXParseException ex) throws SAXException {
         if (IgnoreAllErrorHandler.warnOnExceptions) {
             log.warn("", ex);
@@ -55,6 +66,7 @@
 
 
     /** @inheritDoc */
+    @Override
     public void error(SAXParseException ex) throws SAXException {
         if (IgnoreAllErrorHandler.warnOnExceptions) {
             log.error("", ex);
@@ -66,6 +78,7 @@
 
 
     /** @inheritDoc */
+    @Override
     public void fatalError(SAXParseException ex) throws SAXException {
         if (IgnoreAllErrorHandler.warnOnExceptions) {
             log.warn("", ex);