tree 09b505b35a6c6c43af4e97891af9b24cc3e38ccd
parent f5faae09fa45844ba55326a7f10a475d9e1ee8e3
author Cameron Lee <calee@linkedin.com> 1595969628 -0700
committer GitHub <noreply@github.com> 1595969628 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfIJBcCRBK7hj4Ov3rIwAAdHIIAGlzHTbslyORp3OCQyhW1mis
 Lkd0INaQ+j7Fu9ayR/YynZDCwGTeSjh9E+62xuEb5PnfVwNyprQ3pYWGAq5+phso
 9EjhgQpQJR48/m4ifJgHUaih+uYZetwqnG2qD0hK1bbEJimsoOjz2kFPqWwhUNl6
 KfhabaWK36MFvifIzEA53WGeCm4VTVA0j3h8h1a/Qay8xHXdNGe+xMKy97WOpIfF
 gTwl7ZtuCjkBv0JQkcLqzkw6916Z8mAd+0F0WHVn+Of7FDXgx0wMHfLokDP6G1Bq
 ARF38Qzl9Zu5PAG33a/Ev5asAUIevpk6nb9prx4XudLuNjaylq3RonuGb3CKEKU=
 =7B1U
 -----END PGP SIGNATURE-----
 

SAMZA-2562: [Scala cleanup] Clean up Scala in samza-kv-inmemory and samza-kv-couchbase (#1404)

API changes: I don't think the InMemoryKeyValueStore is part of the Samza API, since InMemoryKeyValueStorageEngineFactory is supposed to be used, but the InMemoryKeyValueStore constructor did change from having one KeyValueStoreMetrics argument with a default value of new KeyValueStoreMetrics to having a required KeyValueStoreMetrics argument. I believe this only applies to Scala usage of InMemoryKeyValueStore, since Java usage requires all arguments (even ones with default values) to be passed anyways.

Upgrade/usage instructions: If using the InMemoryKeyValueStore constructor in another Scala class, then add the KeyValueStoreMetrics argument. It's unlikely that anyone is depending on this constructor explicitly.