commit | f23844ff3001d54df9cde3e93678d2f3520740cc | [log] [tgz] |
---|---|---|
author | Josh Tynjala <joshtynjala@apache.org> | Tue Sep 15 14:28:16 2020 -0700 |
committer | Josh Tynjala <joshtynjala@apache.org> | Tue Sep 15 14:28:16 2020 -0700 |
tree | d8f05926d6d472f5048831c043113172cf50ed67 | |
parent | a940a9b594e5479f8f87fc1dd65b8488fc3cb45f [diff] |
RenamePropertiesWithModuleSupport: break should have been continue
diff --git a/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java b/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java index 44f1b26..c6e6746 100644 --- a/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java +++ b/compiler-jx/src/main/java/com/google/javascript/jscomp/RenamePropertiesWithModuleSupport.java
@@ -451,7 +451,7 @@ if (compiler.getCodingConvention().blockRenamingForProperty(memberDefName)) { externedNames.add(fnName.getString()); } else if(propertyNamesToKeep.contains(memberDefName)) { - break; + continue; } else if (memberDefName.equals("constructor") || memberDefName.equals("superClass_")) { // TODO (simarora) is there a better way to identify these externs?