)]}' { "commit": "472aea78d0ca77144000aacdd932ebb4a8fed192", "tree": "215858f695694b71d6fc92ffa7d7f49c7a483a7d", "parents": [ "1043d0f4de9539b7a861cebcc3925c4acf13a431" ], "author": { "name": "Lorenz Quack", "email": "lquack@apache.org", "time": "Wed Nov 08 14:27:32 2017 +0000" }, "committer": { "name": "Lorenz Quack", "email": "lquack@apache.org", "time": "Wed Nov 08 14:27:32 2017 +0000" }, "message": "NO-JIRA: [Java Client, AMQP 0-x] Remove SerialTest#testCorollary1 test.\n\nThe test seems ill-conceived.\n * The number of iterations for s seems arbitrary (67108664 \u003d 2^26 - 100)\n * The values of n seem arbitrary (0+1, 512+1, 1024+1, 1536+1, ..., 3585)\n * Though arbitrary the values of n have a very specific bit pattern of 10..01\n * s is always incremented by 1024 leading to a very predictable bit pattern in s.\n Namely the 10 least significant bits are always zero.\n * Given the iteration count and the increment the same values of s are tested 16 times!!!\n * Given the above it seems to not focus on interesting corner cases nor is it an exhaustive test.\n\nIn addition to all the above it runs for almost 5 minutes on my box accounting for 80% of all tests.\n", "tree_diff": [ { "type": "modify", "old_id": "08342da9cf80a2be307aa9904b63e578ee4fe78e", "old_mode": 33188, "old_path": "client/src/test/java/org/apache/qpid/util/SerialTest.java", "new_id": "24311c4dc9eafcf91a1406fa99781a8afbf9b841", "new_mode": 33188, "new_path": "client/src/test/java/org/apache/qpid/util/SerialTest.java" } ] }