tree 725ea6642285cdcd017c0055813c55b6f880f898
parent 3ab75cdefb8758efbced97339621f13c7b4d4b15
author Jia Zhai <zhaijia@apache.org> 1602234673 +0800
committer GitHub <noreply@github.com> 1602234673 +0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfgCkxCRBK7hj4Ov3rIwAAdHIIADbbOOTiyPMWRYrTu9Ng3mo6
 vGwQXC358qZz2xIKeqrkve6NdXclmMGpp9XD8BKE5DKt8DyCryJX3xtNqRn93Q0D
 oqilo7uRoa+MbePbElrJg4dmRP1Hgj9o9ZJLjc137L9p7jRWz55U+sktRZYCC1rK
 4u+uENfcutSLtp/vUG0fxknVQ4+m3JCT2HodNeGJqCYcCl8akc4GgcDcSWeOYlTK
 onZEuKRSJF0cu/JxEqz7EHc603q9lgZY3hW965MMc74ASH4JmvWgoxtHF8NntXY7
 F27qOrB6r1F7+HI3RZARoGjjahqX9lO+cOx59qEgMhD8h5VUd2EVbyqfo18ZN5I=
 =6vHL
 -----END PGP SIGNATURE-----
 

Fix deadlock when connection closed (#376)

Fixes #366

### Motivation

In current code of `pulsar/internal/connection.go` we have 2 channels, closeCh and incomingRequestsCh. when the connection closes, the current mis-use of these 2 channels may have a deadlock. 
PR #366 has detailed steps to reproduce and the root cause [analysis](https://github.com/apache/pulsar-client-go/pull/366#issuecomment-696759873) .
This PR tries to fix the deadlock.

### Modifications
- make the close logic independent, not in the same loop of normal events handling.
- when the connection closed, handle the existing requests in the channel and return an error to avoid deadlock.

### Verifying this change
passed the tests in #366 
current ut passed