tree 6803f7cc19b8c9ffd48cf9f2b6c00068e19b332f
parent 3b2d278b45e7c2f3c4ee06f82baacd88be035229
author Rueian <rueiancsie@gmail.com> 1597632241 +0800
committer GitHub <noreply@github.com> 1597632241 +0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfOe7yCRBK7hj4Ov3rIwAAdHIIAI1xX1FwLPnkk4WUPYhq9JPf
 HN/9fe1pAwef0uBWAdkoyhfqzjF7KRPMNBdwGFS4IgoV/jZVfoHqQZRBNi9mOkao
 nPCq7Upbx6CKSvbRT3XNPwyPKDhmAwsg0aEtrAJUvz2lzZtbGsg3reOy9qx6vuEt
 bPJhnwa2MIz1VdJ1AXlhocoFY6q3FJqQdlzyjtWGykcAniO+bki+olUpLry0wH/w
 +t8cNE0IcKwls2g0JDKU0TESfvYwCsRI3rVWe7l53kYTSq9ERoLVJFkAlNETWEBP
 7I7tIcB9YSraHuEp8isv6yHfycKlBerU9eJ9xdIgQ1m6pq+cnOz1e/aASGMuMog=
 =IfAI
 -----END PGP SIGNATURE-----
 

Clean callbacks of connection after run loop stopped (#239) (#248)

Fixes #239

### Motivation

As @wolfstudy pointed out here https://github.com/apache/pulsar-client-go/issues/239#issuecomment-625238240

There is a race on callbacks of `pendingReqs` when closing the connection while the run loop is still running, which will lead to calling a callback up to 2 times:
https://github.com/apache/pulsar-client-go/blob/e7f1673350f208b5063823282d14906d70d66904/pulsar/internal/connection.go#L669-L671

### Modifications

Introducing a `runLoopStoppedCh` to make sure that the run loop has already stopped when cleaning callbacks of `pendingReqs` in the `Close()`