tree e7b5e97819f1ad689f341ffc112af38616249c8c
parent d1c9a07860e365db4e335d24ad67e87544bdcceb
author Marius Volkhart <mariusvolkhart@apache.org> 1614557091 +0000
committer Marius Volkhart <mariusvolkhart@apache.org> 1614557091 +0000

Review EscherContainerRecord#getChildRecords() call sites for unnecessary work

This started off as wanting to add the EscherContainerRecord#getChildCount() function in order to do an efficient check for how many children the container has. This was desirable in new code for editing HSSF pictures. The existing option of calling getChildRecords().size() was undesirable as this requires a list copy first.

In the process of finding call sites that would benefit from replacing getChildRecords().size(), I realized that several other patterns would benefit from eliminating a copy, such as iterating over the children in a for-each loop, and indexed access to specific children.

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887020 13f79535-47bb-0310-9956-ffa450edef68