Remove support for japicmp from Gradle build
I now spent a few hours trying to make it work and the Gradle support is
simply not production-ready and also not maintained, it triggers various
strange errors and does not supporting the usual Gradle conventions.
So I do not want to spend more time on it, feel free to revive it if you know how
to make this work properly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888138 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/build.gradle b/build.gradle
index df2d2ba..b9327fc 100644
--- a/build.gradle
+++ b/build.gradle
@@ -20,8 +20,6 @@
}
dependencies {
- // 2.x fails with "Could not get unknown property 'me'"
- classpath 'me.champeau.gradle:japicmp-gradle-plugin:0.1.2'
classpath "org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:3.0"
}
}
@@ -88,16 +86,12 @@
apply plugin: 'java-library'
apply plugin: 'jacoco'
- // See https://github.com/melix/japicmp-gradle-plugin
- apply plugin: 'me.champeau.gradle.japicmp'
-
version = '5.0.1-SNAPSHOT'
ext {
bouncyCastleVersion = '1.68'
commonsCodecVersion = '1.15'
commonsCompressVersion = '1.20'
commonsMathVersion = '3.6.1'
- japicmpversion = '5.0.0'
junitVersion = '5.7.0'
log4jVersion = '2.14.0'
mockitoVersion = '3.6.0'
@@ -204,13 +198,4 @@
}
}
}
-
- task(japicmp, type: me.champeau.gradle.ArtifactJapicmpTask, dependsOn: jar) {
- to = jar.archivePath
- onlyModified = true
- onlyBinaryIncompatibleModified = true
- failOnModification = false
- txtOutputFile = file("$buildDir/reports/japi.txt")
- htmlOutputFile = file("$buildDir/reports/japi.html")
- }
}
\ No newline at end of file
diff --git a/build.xml b/build.xml
index 8ea0ec8..4ff0352 100644
--- a/build.xml
+++ b/build.xml
@@ -3057,7 +3057,6 @@
</loadresource>
<replaceregexp file="build.gradle" match="( +version += +)'[^']+'" replace="\1'${version.id}'"/>
- <replaceregexp file="build.gradle" match="(japicmpversion += +)'[^']+'" replace="\1'${rel_prev}'"/>
<replaceregexp file="examples/src/main/groovy/build.gradle" match="( *compile 'org.apache.poi:[^0-9]+)([0-9.]+)'" replace="\1${rel_prev}'" byline="true"/>
<replaceregexp file="examples/src/main/scala/build.sbt" match='( *org.apache.poi.* ")[0-9.]+(.+)' replace="\1${rel_prev}\2" byline="true"/>
<replaceregexp file="osgi/pom.xml" match="version>${rel_prev}[^<]+" replace="version>${version.id}"/>
diff --git a/examples/build.gradle b/examples/build.gradle
index eb7855d..559dd44 100644
--- a/examples/build.gradle
+++ b/examples/build.gradle
@@ -21,5 +21,3 @@
implementation "org.apache.logging.log4j:log4j-core:${log4jVersion}"
}
-
-japicmp.enabled = false
\ No newline at end of file
diff --git a/excelant/build.gradle b/excelant/build.gradle
index fb65866..e9889fe 100644
--- a/excelant/build.gradle
+++ b/excelant/build.gradle
@@ -28,5 +28,3 @@
attributes 'Automatic-Module-Name': 'org.apache.poi.excelant'
}
}
-
-japicmp.baseline = "org.apache.poi:poi-excelant:${japicmpversion}@jar"
\ No newline at end of file
diff --git a/integrationtest/build.gradle b/integrationtest/build.gradle
index 0121e71..31ad899 100644
--- a/integrationtest/build.gradle
+++ b/integrationtest/build.gradle
@@ -35,5 +35,3 @@
// exclude these from the normal test-run
exclude '**/*FileHandler.class'
}
-
-japicmp.enabled = false
\ No newline at end of file
diff --git a/jenkins/create_jobs.groovy b/jenkins/create_jobs.groovy
index 4a66735..9de575e 100644
--- a/jenkins/create_jobs.groovy
+++ b/jenkins/create_jobs.groovy
@@ -56,7 +56,8 @@
],
[ name: 'POI-DSL-regenerate-javadoc', trigger: triggerSundays, javadoc: true
],
- [ name: 'POI-DSL-API-Check', trigger: '@daily', apicheck: true
+ // it was impossible to make this run stable in Gradle, thus disabling this for now
+ [ name: 'POI-DSL-API-Check', trigger: '@daily', apicheck: true, disabled: true
],
[ name: 'POI-DSL-Gradle', trigger: triggerSundays, email: 'centic@apache.org', gradle: true,
// Gradle will not run any tests if the code is up-to-date, therefore manually mark the files as updated
@@ -381,23 +382,6 @@
}
mailer(email, false, false)
}
- } else if (poijob.apicheck) {
- steps {
- shellEx(delegate, shellcmds, poijob)
- gradle {
- tasks('japicmp')
- useWrapper(true)
- }
- }
- publishers {
- archiveArtifacts('build/*/build/reports/japi.html')
- if (!poijob.skipcigame) {
- configure { project ->
- project / publishers << 'hudson.plugins.cigame.GamePublisher' {}
- }
- }
- mailer(email, false, false)
- }
} else if(poijob.sonar) {
steps {
shellEx(delegate, shellcmds, poijob)
diff --git a/main/build.gradle b/main/build.gradle
index 5167b32..f561dfb 100644
--- a/main/build.gradle
+++ b/main/build.gradle
@@ -46,5 +46,3 @@
artifacts {
tests testJar
}
-
-japicmp.baseline = "org.apache.poi:poi:${japicmpversion}@jar"
\ No newline at end of file
diff --git a/ooxml-schema/build.gradle b/ooxml-schema/build.gradle
index 68aa790..2aaa0d7 100644
--- a/ooxml-schema/build.gradle
+++ b/ooxml-schema/build.gradle
@@ -66,5 +66,3 @@
attributes 'Automatic-Module-Name': 'org.apache.poi.ooxml.schemas'
}
}
-
-japicmp.baseline = "org.apache.poi:poi:${japicmpversion}@jar"
diff --git a/ooxml/build.gradle b/ooxml/build.gradle
index 58ff2a4..2937e48 100644
--- a/ooxml/build.gradle
+++ b/ooxml/build.gradle
@@ -50,8 +50,6 @@
}
}
-japicmp.baseline = "org.apache.poi:poi:${japicmpversion}@jar"
-
test {
// for some reason catching the OOM does not work when run from Gradle
exclude '**/MemoryUsage.class'
diff --git a/scratchpad/build.gradle b/scratchpad/build.gradle
index 9b0717e..83a4e09 100644
--- a/scratchpad/build.gradle
+++ b/scratchpad/build.gradle
@@ -29,5 +29,3 @@
attributes 'Automatic-Module-Name': 'org.apache.poi.scratchpad'
}
}
-
-japicmp.baseline = "org.apache.poi:poi:${japicmpversion}@jar"
\ No newline at end of file
