tree e6c154db26d122265a603d70f3ecfbda2ac95d12
parent 494658a1f3f411c624dc49f191511febccd0d04c
author Joshua Storck <joshua.storck@twosigma.com> 1524048923 +0200
committer Uwe L. Korn <uwe@apache.org> 1524048923 +0200

PARQUET-1274: Prevent segfault that was occurring when writing a nanosecond timestamp with arrow writer properties set to coerce timestamps and support deprecated int96 timestamps.

The bug was a due to the fact that the physical type was int64 but the WriteTimestamps function was taking a path that assumed the physical type was int96. This caused memory corruption because it was writing past the end of the array. The bug was fixed by checking that coerce timestamps is disabled when writing int96.

A unit test was added for the regression.

Author: Joshua Storck <joshua.storck@twosigma.com>

Closes #456 from joshuastorck/ARROW_2082 and squashes the following commits:

5fa0a94 [Joshua Storck] Removing 'using ::arrow' in favor of using ::arrow::SomeType
9725ecc [Joshua Storck] Bug fix for ARROW-2082, in which a segfault was being encountered when writing a nanosecond timestamp column with arrow writer properties set to coerce timestamps and support deprecated int96 timestamps. The bug was a segfault due to the fact that the physical type was int64 but the WriteTimestamps function was taking a path that assumed the physical type was int96. The bug was fixed by checking that coerce timestamps is disabled when writing int96. A unit test was added for the regression