tree 2ae038ded9da0c2c27e0309254fee30bbbec7eee
parent 0631278fd537affbacbcfca008fe0fb8cef0c99a
author bjugl <61057136+bjugl@users.noreply.github.com> 1617354762 +0200
committer GitHub <noreply@github.com> 1617354762 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgZuAKCRBK7hj4Ov3rIwAAdHIIABZfCZg+egk+vm7ey+w4fw1k
 byrU40gpjek0k3ltSnS3Lubbr5kKlGcl+Wwf4+TVvXHemf1SrZZfOHJztUsCr9C7
 zZhl/ap0K/MQPAz2V0LFHz8yJmAtNiSxOWx4+l85nSXNJhMzTiXTX928+eWmbnZZ
 5nPErehj61JEvJfJVsynKoMgTtXPL9hd5N13NeT0YwK5cWLWg7JvTv10tmF2zg7i
 FHCu3TY9o0UDUGOz8wDUXU4/R4kvkI8wnBp0R7L89n5OcklpswnQ8TetMKf01LS3
 JY0wYzfsdccik5keluxdsRn9eH8ChoGHt7e44RYdaozgi6/15waIQyykZc/Vdag=
 =lF9o
 -----END PGP SIGNATURE-----
 

Fixed: Induction from DB does not represent relations properly. (#290) (OFBIZ-12178)

As encountered in OFBIZ-6510, the ModelInduceFromDb does currently not include entity relations and foreign key constraints. Since they are an important part of the database model, we should fix that.

I could track down the problem to an incomplete invocation of the ModelEntity through the constructor used in the DatabaseUtil.induceModelFromDb() Methods. This constructor does not initialize the Relations.

Problem is, that the ModelEntity initialized through the "DB Names Constructor" does not cover references in its current state at all.

While working on an implementation I realized, that the API is not very congruent in this regards. I would expect that I could initialize ModelRelations the same way ModelFields are initialized in this context:

The create() Method takes a ModelEntity, DatabaseUtil.ColumnCheckInfo (respectively a DatabaseUtil.ReferenceCheckInfo) and a ModelFieldTypeReader (that could be left out for references) and creates ModelField (ModelRelation) objects that are added to the ModelEntity.

But that is not the case at the moment. On one hand not all fields that would be necessary are covered in the DatabaseUtil.ReferenceCheckInfo Objects (e.g. "type" is missing), on the other the object is missing public getters to make the values available in the first place.

Thanks a bunch Benjamin, nice add !