commit a4aad284eb1ea78f3700d49cf7caedf291e81b04
author hujun5 <hujun5@xiaomi.com> Mon Dec 11 11:59:12 2023 +0800
committer Xiang Xiao <xiaoxiang781216@gmail.com> Wed May 01 11:08:07 2024 +0800
tree edeea54bd09d39c3f1e5e2a8c94204a0d6a8c80c
parent 4482d7b88276f80633689cb0f2524c02bc69a8c7

sched: wqueue: Remove sched_[un]lock from kwork_inherit.c

purpose:
1 sched_lock is very time-consuming, and reducing its invocations can improve performance.
2 sched_lock is prone to misuse, and narrowing its scope of use is to prevent people from referencing incorrect code and using it

test:
We can use qemu for testing.
compiling
make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20
running
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx

We have also tested this patch on other ARM hardware platforms.

Signed-off-by: hujun5 <hujun5@xiaomi.com>

sched/wqueue/kwork_inherit.c

diff --git a/sched/wqueue/kwork_inherit.c b/sched/wqueue/kwork_inherit.c
index ebd2eb7..920fcc0 100644
--- a/sched/wqueue/kwork_inherit.c
+++ b/sched/wqueue/kwork_inherit.c
@@ -219,7 +219,6 @@
   /* Prevent context switches until we get the priorities right */
 
   flags = enter_critical_section();
-  sched_lock();
 
   /* Adjust the priority of every worker thread */
 
@@ -228,7 +227,6 @@
       lpwork_boostworker(lpwork().worker[wndx].pid, reqprio);
     }
 
-  sched_unlock();
   leave_critical_section(flags);
 }
 
@@ -265,7 +263,6 @@
   /* Prevent context switches until we get the priorities right */
 
   flags = enter_critical_section();
-  sched_lock();
 
   /* Adjust the priority of every worker thread */
 
@@ -274,7 +271,6 @@
       lpwork_restoreworker(lpwork().worker[wndx].pid, reqprio);
     }
 
-  sched_unlock();
   leave_critical_section(flags);
 }