tree cd6ae5fac39d360e08518d9c1e18604b4a652d4e
parent f7933308dbc1cbd2b983f4debaa2ae1368fc8f06
author Charles-Francois Natali <cf.natali@gmail.com> 1651428644 +0100
committer cf-natali <cf.natali@gmail.com> 1651435349 +0100

Fixed random SlaveRecoveryTest.PingTimeoutDuringRecovery test failure.

This test would randomly fail with:
```
18:16:59 3: F0501 17:16:59.192818 19175 slave.cpp:1445] Check failed:
   state == DISCONNECTED || state == RUNNING || state == TERMINATING
RECOVERING
```

The cause was that the test re-starts the slave with the same PID, which
means that timers started by the previous slave process could fire while
the new slave process was running.

In this specific case, what happened is that the previous slave's ping
timer would fire in the middle of recovery of the second slave instance,
yielding this assertion.

Fixed by making sure to use `Clock::advance` and `Clock::settle` after
terminating the first instance to ensure that there are no pending
timers.

Tested by running the test in a loop, while running a CPU-intensive
workload - `stress-ng --cpu $(nproc)0` in parallel.