Use isEmpty instead of length (#1420)
Signed-off-by: crazyhzm <crazyhzm@apache.org>
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
index 9650034..32bbb89f 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
@@ -142,8 +142,8 @@ public static VersionRange createFromVersionSpec(String spec) throws InvalidVers
}
}
- if (process.length() > 0) {
- if (restrictions.size() > 0) {
+ if (!process.isEmpty()) {
+ if (!restrictions.isEmpty()) {
throw new InvalidVersionSpecificationException(
"Only fully-qualified sets allowed in multiple set scenario: " + spec);
} else {
@@ -180,11 +180,11 @@ private static Restriction parseRestriction(String spec) throws InvalidVersionSp
String upperBound = process.substring(index + 1).trim();
ArtifactVersion lowerVersion = null;
- if (lowerBound.length() > 0) {
+ if (!lowerBound.isEmpty()) {
lowerVersion = new DefaultArtifactVersion(lowerBound);
}
ArtifactVersion upperVersion = null;
- if (upperBound.length() > 0) {
+ if (!upperBound.isEmpty()) {
upperVersion = new DefaultArtifactVersion(upperBound);
}
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/repository/LegacyLocalRepositoryManager.java b/maven-compat/src/main/java/org/apache/maven/artifact/repository/LegacyLocalRepositoryManager.java
index 6034d84..5386d44 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/repository/LegacyLocalRepositoryManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/repository/LegacyLocalRepositoryManager.java
@@ -179,11 +179,11 @@ static class ArtifactMetadataAdapter implements ArtifactMetadata {
}
public boolean storedInArtifactVersionDirectory() {
- return metadata.getVersion().length() > 0;
+ return !metadata.getVersion().isEmpty();
}
public boolean storedInGroupDirectory() {
- return metadata.getArtifactId().length() <= 0;
+ return metadata.getArtifactId().isEmpty();
}
public String getGroupId() {
@@ -199,7 +199,7 @@ public String getBaseVersion() {
}
private String nullify(String str) {
- return (str == null || str.length() <= 0) ? null : str;
+ return (str == null || str.isEmpty()) ? null : str;
}
public Object getKey() {
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java b/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
index 3dd264b..509624b 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
@@ -54,7 +54,7 @@ public String pathOf(Artifact artifact) {
}
if (artifactHandler.getExtension() != null
- && artifactHandler.getExtension().length() > 0) {
+ && !artifactHandler.getExtension().isEmpty()) {
path.append(GROUP_SEPARATOR).append(artifactHandler.getExtension());
}
diff --git a/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java b/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
index 9a6bc49..e08b2e2 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
@@ -204,7 +204,7 @@ public String unalignFromBaseDirectory(String path, File basedir) {
path = chopLeadingFileSeparator(path.substring(base.length()));
}
- if (path.length() <= 0) {
+ if (path.isEmpty()) {
path = ".";
}
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
index ccb18d2..8051ded 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
@@ -33,7 +33,7 @@ class MavenArtifact implements ArtifactTransferResource {
MavenArtifact(String repositoryUrl, Resource resource) {
if (repositoryUrl == null) {
this.repositoryUrl = "";
- } else if (!repositoryUrl.endsWith("/") && repositoryUrl.length() > 0) {
+ } else if (!repositoryUrl.endsWith("/") && !repositoryUrl.isEmpty()) {
this.repositoryUrl = repositoryUrl + '/';
} else {
this.repositoryUrl = repositoryUrl;
diff --git a/maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java b/maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
index 6631e61..4f4fadb 100644
--- a/maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
+++ b/maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
@@ -56,7 +56,7 @@ public String getPathForLocalArtifact(Artifact artifact) {
path.append(artifact.getArtifactId()).append('-').append(artifact.getVersion());
- if (artifact.getClassifier().length() > 0) {
+ if (!artifact.getClassifier().isEmpty()) {
path.append('-').append(artifact.getClassifier());
}
@@ -84,13 +84,13 @@ String getRepositoryKey(RemoteRepository repository, String context) {
private String getPath(Metadata metadata, String repositoryKey) {
StringBuilder path = new StringBuilder(128);
- if (metadata.getGroupId().length() > 0) {
+ if (!metadata.getGroupId().isEmpty()) {
path.append(metadata.getGroupId().replace('.', '/')).append('/');
- if (metadata.getArtifactId().length() > 0) {
+ if (!metadata.getArtifactId().isEmpty()) {
path.append(metadata.getArtifactId()).append('/');
- if (metadata.getVersion().length() > 0) {
+ if (!metadata.getVersion().isEmpty()) {
path.append(metadata.getVersion()).append('/');
}
}
diff --git a/maven-core/src/main/java/org/apache/maven/RepositoryUtils.java b/maven-core/src/main/java/org/apache/maven/RepositoryUtils.java
index e94554d..b2da5bc 100644
--- a/maven-core/src/main/java/org/apache/maven/RepositoryUtils.java
+++ b/maven-core/src/main/java/org/apache/maven/RepositoryUtils.java
@@ -66,7 +66,7 @@
public class RepositoryUtils {
private static String nullify(String string) {
- return (string == null || string.length() <= 0) ? null : string;
+ return (string == null || string.isEmpty()) ? null : string;
}
private static org.apache.maven.artifact.Artifact toArtifact(Dependency dependency) {
@@ -207,7 +207,7 @@ public static String getLayout(ArtifactRepository repo) {
String className = repo.getLayout().getClass().getSimpleName();
if (className.endsWith("RepositoryLayout")) {
String layout = className.substring(0, className.length() - "RepositoryLayout".length());
- if (layout.length() > 0) {
+ if (!layout.isEmpty()) {
layout = Character.toLowerCase(layout.charAt(0)) + layout.substring(1);
return layout;
}
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java b/maven-core/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java
index e933202..e963886 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/repository/layout/DefaultRepositoryLayout.java
@@ -56,7 +56,7 @@ public String pathOf(Artifact artifact) {
}
if (artifactHandler.getExtension() != null
- && artifactHandler.getExtension().length() > 0) {
+ && !artifactHandler.getExtension().isEmpty()) {
path.append(GROUP_SEPARATOR).append(artifactHandler.getExtension());
}
diff --git a/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java b/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java
index f782763..3207e7b 100644
--- a/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java
+++ b/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java
@@ -39,7 +39,7 @@ protected Object fromExpression(
String value = configuration.getValue();
try {
Object result = null;
- if (null != value && value.length() > 0) {
+ if (null != value && !value.isEmpty()) {
if (evaluator instanceof TypeAwareExpressionEvaluator) {
result = ((TypeAwareExpressionEvaluator) evaluator).evaluate(value, type);
} else {
@@ -48,7 +48,7 @@ protected Object fromExpression(
}
if (null == result && configuration.getChildCount() == 0) {
value = configuration.getAttribute("default-value");
- if (null != value && value.length() > 0) {
+ if (null != value && !value.isEmpty()) {
if (evaluator instanceof TypeAwareExpressionEvaluator) {
result = ((TypeAwareExpressionEvaluator) evaluator).evaluate(value, type);
} else {
diff --git a/maven-core/src/main/java/org/apache/maven/project/ExtensionDescriptorBuilder.java b/maven-core/src/main/java/org/apache/maven/project/ExtensionDescriptorBuilder.java
index e4d2ef5..cd84aa8 100644
--- a/maven-core/src/main/java/org/apache/maven/project/ExtensionDescriptorBuilder.java
+++ b/maven-core/src/main/java/org/apache/maven/project/ExtensionDescriptorBuilder.java
@@ -115,7 +115,7 @@ private List<String> parseStrings(XmlNode dom) {
String string = child.getValue();
if (string != null) {
string = string.trim();
- if (string.length() > 0) {
+ if (!string.isEmpty()) {
strings.add(string);
}
}
diff --git a/maven-core/src/main/java/org/apache/maven/project/MavenProject.java b/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
index 0e165e0..987130a 100644
--- a/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
+++ b/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
@@ -287,7 +287,7 @@ public DependencyManagement getDependencyManagement() {
private void addPath(List<String> paths, String path) {
if (path != null) {
path = path.trim();
- if (path.length() > 0) {
+ if (!path.isEmpty()) {
File file = new File(path);
if (file.isAbsolute()) {
path = file.getAbsolutePath();
diff --git a/maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java b/maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
index b49af81..91be145 100644
--- a/maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
+++ b/maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java
@@ -56,7 +56,7 @@ public String getPathForLocalArtifact(Artifact artifact) {
path.append(artifact.getArtifactId()).append('-').append(artifact.getVersion());
- if (artifact.getClassifier().length() > 0) {
+ if (!artifact.getClassifier().isEmpty()) {
path.append('-').append(artifact.getClassifier());
}
@@ -84,13 +84,13 @@ String getRepositoryKey(RemoteRepository repository, String context) {
private String getPath(Metadata metadata, String repositoryKey) {
StringBuilder path = new StringBuilder(128);
- if (metadata.getGroupId().length() > 0) {
+ if (!metadata.getGroupId().isEmpty()) {
path.append(metadata.getGroupId().replace('.', '/')).append('/');
- if (metadata.getArtifactId().length() > 0) {
+ if (!metadata.getArtifactId().isEmpty()) {
path.append(metadata.getArtifactId()).append('/');
- if (metadata.getVersion().length() > 0) {
+ if (!metadata.getVersion().isEmpty()) {
path.append(metadata.getVersion()).append('/');
}
}
diff --git a/maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java b/maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
index 1a62135..1cc4eff 100644
--- a/maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
+++ b/maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
@@ -116,7 +116,7 @@ private String path(Artifact artifact) {
path.append(artifact.getArtifactId()).append('-').append(artifact.getVersion());
- if (artifact.getClassifier().length() > 0) {
+ if (!artifact.getClassifier().isEmpty()) {
path.append('-').append(artifact.getClassifier());
}
diff --git a/maven-core/src/test/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformationTest.java b/maven-core/src/test/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformationTest.java
index 7a96988..e04b13a 100644
--- a/maven-core/src/test/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformationTest.java
+++ b/maven-core/src/test/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformationTest.java
@@ -38,7 +38,7 @@ class DefaultRuntimeInformationTest {
void testGetMavenVersion() {
String mavenVersion = rtInfo.getMavenVersion();
assertNotNull(mavenVersion);
- assertTrue(mavenVersion.length() > 0);
+ assertTrue(!mavenVersion.isEmpty());
}
@Test
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
index caeae60..22971e4 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@@ -1152,7 +1152,7 @@ private org.apache.maven.api.model.Model doReadFileModel(
throw problems.newModelBuildingException();
} catch (IOException e) {
String msg = e.getMessage();
- if (msg == null || msg.length() <= 0) {
+ if (msg == null || msg.isEmpty()) {
// NOTE: There's java.nio.charset.MalformedInputException and sun.io.MalformedInputException
if (e.getClass().getName().endsWith("MalformedInputException")) {
msg = "Some input bytes do not match the file encoding.";
@@ -1560,7 +1560,7 @@ private ModelSource2 getParentPomFile(Model childModel, Source source) {
String parentPath = childModel.getParent().getRelativePath();
- if (parentPath == null || parentPath.length() <= 0) {
+ if (parentPath == null || parentPath.isEmpty()) {
return null;
}
@@ -1605,7 +1605,7 @@ private ModelData readParentExternally(
}
buffer.append(": ").append(e.getMessage());
if (childModel.getProjectDirectoryPath() != null) {
- if (parent.getRelativePath() == null || parent.getRelativePath().length() <= 0) {
+ if (parent.getRelativePath() == null || parent.getRelativePath().isEmpty()) {
buffer.append(" and 'parent.relativePath' points at no local POM");
} else {
buffer.append(" and 'parent.relativePath' points at wrong local POM");
@@ -1710,21 +1710,21 @@ private DependencyManagement loadDependencyManagement(
String artifactId = dependency.getArtifactId();
String version = dependency.getVersion();
- if (groupId == null || groupId.length() <= 0) {
+ if (groupId == null || groupId.isEmpty()) {
problems.add(new ModelProblemCollectorRequest(Severity.ERROR, ModelProblem.Version.BASE)
.setMessage("'dependencyManagement.dependencies.dependency.groupId' for "
+ dependency.getManagementKey() + " is missing.")
.setLocation(dependency.getLocation("")));
return null;
}
- if (artifactId == null || artifactId.length() <= 0) {
+ if (artifactId == null || artifactId.isEmpty()) {
problems.add(new ModelProblemCollectorRequest(Severity.ERROR, ModelProblem.Version.BASE)
.setMessage("'dependencyManagement.dependencies.dependency.artifactId' for "
+ dependency.getManagementKey() + " is missing.")
.setLocation(dependency.getLocation("")));
return null;
}
- if (version == null || version.length() <= 0) {
+ if (version == null || version.isEmpty()) {
problems.add(new ModelProblemCollectorRequest(Severity.ERROR, ModelProblem.Version.BASE)
.setMessage("'dependencyManagement.dependencies.dependency.version' for "
+ dependency.getManagementKey() + " is missing.")
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java
index ffb3e33..da2b086 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelBuildingException.java
@@ -137,7 +137,7 @@ static String toMessage(String modelId, List<ModelProblem> problems) {
writer.print(problems.size());
writer.print((problems.size() == 1) ? " problem was " : " problems were ");
writer.print("encountered while building the effective model");
- if (modelId != null && modelId.length() > 0) {
+ if (modelId != null && !modelId.isEmpty()) {
writer.print(" for ");
writer.print(modelId);
}
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java
index 3d373eb..d9646ff 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java
@@ -102,11 +102,11 @@ static String toId(org.apache.maven.api.model.Model model) {
static String toId(String groupId, String artifactId, String version) {
StringBuilder buffer = new StringBuilder(128);
- buffer.append((groupId != null && groupId.length() > 0) ? groupId : "[unknown-group-id]");
+ buffer.append((groupId != null && !groupId.isEmpty()) ? groupId : "[unknown-group-id]");
buffer.append(':');
- buffer.append((artifactId != null && artifactId.length() > 0) ? artifactId : "[unknown-artifact-id]");
+ buffer.append((artifactId != null && !artifactId.isEmpty()) ? artifactId : "[unknown-artifact-id]");
buffer.append(':');
- buffer.append((version != null && version.length() > 0) ? version : "[unknown-version]");
+ buffer.append((version != null && !version.isEmpty()) ? version : "[unknown-version]");
return buffer.toString();
}
@@ -127,7 +127,7 @@ public static String formatLocation(ModelProblem problem, String projectId) {
if (!problem.getModelId().equals(projectId)) {
buffer.append(problem.getModelId());
- if (problem.getSource().length() > 0) {
+ if (!problem.getSource().isEmpty()) {
if (buffer.length() > 0) {
buffer.append(", ");
}
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
index 0a3e36f..5058859 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
@@ -167,7 +167,7 @@ private String appendPath(String parentUrl, String childPath, String pathAdjustm
}
private void concatPath(StringBuilder url, String path) {
- if (path.length() > 0) {
+ if (!path.isEmpty()) {
boolean initialUrlEndsWithSlash = url.charAt(url.length() - 1) == '/';
boolean pathStartsWithSlash = path.charAt(0) == '/';
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java
index d90eb2a..5659c43 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/ProblemDetectingValueSource.java
@@ -54,7 +54,7 @@ public Object getValue(String expression) {
if (value != null && expression.startsWith(bannedPrefix)) {
String msg = "The expression ${" + expression + "} is deprecated.";
- if (newPrefix != null && newPrefix.length() > 0) {
+ if (newPrefix != null && !newPrefix.isEmpty()) {
msg += " Please use ${" + newPrefix + expression.substring(bannedPrefix.length()) + "} instead.";
}
problems.add(new ModelProblemCollectorRequest(Severity.WARNING, Version.V20).setMessage(msg));
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java b/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java
index fc7493f..0f87436 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelWriter.java
@@ -71,7 +71,7 @@ public void write(OutputStream output, Map<String, Object> options, Model model)
Objects.requireNonNull(model, "model cannot be null");
String encoding = model.getModelEncoding();
- if (encoding == null || encoding.length() <= 0) {
+ if (encoding == null || encoding.isEmpty()) {
encoding = "UTF-8";
}
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java b/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java
index 71f7fa3..23f4320 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java
@@ -63,7 +63,7 @@ public boolean isActive(Profile profile, ProfileActivationContext context, Model
String version = context.getSystemProperties().get("java.version");
- if (version == null || version.length() <= 0) {
+ if (version == null || version.isEmpty()) {
problems.add(new ModelProblemCollectorRequest(Severity.ERROR, Version.BASE)
.setMessage("Failed to determine Java version for profile " + profile.getId())
.setLocation(activation.getLocation("jdk")));
@@ -110,7 +110,7 @@ private static boolean isInRange(String value, List<RangeValue> range) {
}
private static int getRelationOrder(String value, RangeValue rangeValue, boolean isLeft) {
- if (rangeValue.value.length() <= 0) {
+ if (rangeValue.value.isEmpty()) {
return isLeft ? 1 : -1;
}
@@ -159,7 +159,7 @@ private static List<RangeValue> getRange(String range) {
ranges.add(new RangeValue(token.replace("]", ""), true));
} else if (token.endsWith(")")) {
ranges.add(new RangeValue(token.replace(")", ""), false));
- } else if (token.length() <= 0) {
+ } else if (token.isEmpty()) {
ranges.add(new RangeValue("", false));
}
}
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivator.java b/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivator.java
index 3941655..d8cb0be 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivator.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivator.java
@@ -61,7 +61,7 @@ public boolean isActive(Profile profile, ProfileActivationContext context, Model
name = name.substring(1);
}
- if (name == null || name.length() <= 0) {
+ if (name == null || name.isEmpty()) {
problems.add(new ModelProblemCollectorRequest(Severity.ERROR, Version.BASE)
.setMessage("The property name is required to activate the profile " + profile.getId())
.setLocation(property.getLocation("")));
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java b/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
index 25f4328..23c602d 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
@@ -1355,7 +1355,7 @@ private boolean validateStringNotEmpty(
return false;
}
- if (string.length() > 0) {
+ if (!string.isEmpty()) {
return true;
}
@@ -1427,7 +1427,7 @@ private boolean validateBoolean(
String string,
String sourceHint,
InputLocationTracker tracker) {
- if (string == null || string.length() <= 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
@@ -1458,7 +1458,7 @@ private boolean validateEnum(
String sourceHint,
InputLocationTracker tracker,
String... validValues) {
- if (string == null || string.length() <= 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
@@ -1483,7 +1483,7 @@ private boolean validateEnum(
@SuppressWarnings("checkstyle:parameternumber")
private boolean validateModelVersion(
ModelProblemCollector problems, String string, InputLocationTracker tracker, List<String> validVersions) {
- if (string == null || string.length() <= 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
@@ -1598,7 +1598,7 @@ private boolean validateVersion(
String string,
String sourceHint,
InputLocationTracker tracker) {
- if (string == null || string.length() <= 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
@@ -1626,7 +1626,7 @@ private boolean validate20ProperSnapshotVersion(
String string,
String sourceHint,
InputLocationTracker tracker) {
- if (string == null || string.length() <= 0) {
+ if (string == null || string.isEmpty()) {
return true;
}
@@ -1663,7 +1663,7 @@ private boolean validate20PluginVersion(
return false;
}
- if (string.length() <= 0 || "RELEASE".equals(string) || "LATEST".equals(string)) {
+ if (string.isEmpty() || "RELEASE".equals(string) || "LATEST".equals(string)) {
addViolation(
problems,
errOn30,
diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
index 12fe547..4c067ef 100644
--- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
+++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
@@ -614,8 +614,8 @@ public void setThreadSafe(boolean threadSafe) {
* @return {@code true} if this mojo forks either a goal or the lifecycle, {@code false} otherwise.
*/
public boolean isForking() {
- return (getExecuteGoal() != null && getExecuteGoal().length() > 0)
- || (getExecutePhase() != null && getExecutePhase().length() > 0);
+ return (getExecuteGoal() != null && !getExecuteGoal().isEmpty())
+ || (getExecutePhase() != null && !getExecutePhase().isEmpty());
}
public boolean isV4Api() {
diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
index 72208aa..e0f8b8b 100644
--- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
+++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java
@@ -110,7 +110,7 @@ public String getVersion() {
@Override
public Artifact setVersion(String version) {
String current = getVersion();
- if (current.equals(version) || (version == null && current.length() <= 0)) {
+ if (current.equals(version) || (version == null && current.isEmpty())) {
return this;
}
return new RelocatedArtifact(artifact, groupId, artifactId, classifier, extension, version, message);
diff --git a/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java b/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java
index b81de62..23d5ba3 100644
--- a/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java
+++ b/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java
@@ -129,7 +129,7 @@ public SettingsBuildingResult build(SettingsBuildingRequest request) throws Sett
// for the special case of a drive-relative Windows path, make sure it's absolute to save plugins from trouble
String localRepository = userSettings.getLocalRepository();
- if (localRepository != null && localRepository.length() > 0) {
+ if (localRepository != null && !localRepository.isEmpty()) {
File file = new File(localRepository);
if (!file.isAbsolute() && file.getPath().startsWith(File.separator)) {
userSettings.setLocalRepository(file.getAbsolutePath());
diff --git a/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java b/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java
index b00422e..34d49cb 100644
--- a/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java
+++ b/maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java
@@ -78,7 +78,7 @@ public int getColumnNumber() {
public String getLocation() {
StringBuilder buffer = new StringBuilder(256);
- if (getSource().length() > 0) {
+ if (!getSource().isEmpty()) {
if (buffer.length() > 0) {
buffer.append(", ");
}
@@ -111,7 +111,7 @@ public Exception getException() {
public String getMessage() {
String msg;
- if (message != null && message.length() > 0) {
+ if (message != null && !message.isEmpty()) {
msg = message;
} else {
msg = exception.getMessage();
diff --git a/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java b/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java
index 143ff8a..1894c84 100644
--- a/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java
+++ b/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java
@@ -288,7 +288,7 @@ private static boolean validateStringNotEmpty(
return false;
}
- if (string.length() > 0) {
+ if (!string.isEmpty()) {
return true;
}
