Google Git
Sign in
apache / maven-wrapper / f86c2f8766e28cddfbaadca320f60aa031173df6
commitf86c2f8766e28cddfbaadca320f60aa031173df6[log] [tgz]
authorTim te Beek <timtebeek@gmail.com>Sun Jan 08 16:32:35 2023 +0100
committerGitHub <noreply@github.com>Sun Jan 08 16:32:35 2023 +0100
tree6448b2bc414b241f67ff18f875f57f21f6516c40
parent8b48a3f437b9df1249bccd7920f84f587bd20e32 [diff]
Switch to JUnit Jupiter (#61)

* Switch to JUnit Jupiter

Using https://docs.openrewrite.org/reference/recipes/java/testing/junit5/junit5bestpractices

```
mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run \
  -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:1.32.0
\
  -DactiveRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices
```

```
Changes have been made to maven-wrapper/pom.xml by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.UseMockitoExtension
                org.openrewrite.java.testing.mockito.Mockito1to4Migration
                    org.openrewrite.maven.UpgradeDependencyVersion:
{groupId=org.mockito, artifactId=*, newVersion=4.x, retainVersions=[]}
            org.openrewrite.maven.RemoveDependency: {groupId=junit,
artifactId=junit}
            org.openrewrite.maven.AddDependency:
{groupId=org.junit.jupiter, artifactId=junit-jupiter, version=5.x,
onlyIfUsing=org.junit.jupiter.api.Test}
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.AssertToAssertions
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport:
{methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/PathAssemblerTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.AssertToAssertions
            org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/DownloaderTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.AssertToAssertions
            org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/HashAlgorithmVerifierTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.AssertToAssertions
            org.openrewrite.java.testing.junit5.TemporaryFolderToTempDir
            org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport:
{methodPattern=org.junit.jupiter.api.Assertions *(..)}
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/InstallerTest.java
by:
    org.openrewrite.java.testing.junit5.JUnit5BestPractices
        org.openrewrite.java.testing.junit5.JUnit4to5Migration
            org.openrewrite.java.testing.junit5.AssertToAssertions
            org.openrewrite.java.testing.junit5.TemporaryFolderToTempDir
            org.openrewrite.java.testing.junit5.UpdateBeforeAfterAnnotations
            org.openrewrite.java.testing.junit5.UpdateTestAnnotation
        org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic
        org.openrewrite.java.testing.junit5.StaticImports
            org.openrewrite.java.UseStaticImport:
{methodPattern=org.junit.jupiter.api.Assertions *(..)}
```

* Spotless apply

* Introduce properties for JUnit and Mockito versions
7 files changed
tree: 6448b2bc414b241f67ff18f875f57f21f6516c40
  1. .github/
  2. maven-wrapper/
  3. maven-wrapper-distribution/
  4. maven-wrapper-plugin/
  5. src/
  6. .asf.yaml
  7. .gitignore
  8. Jenkinsfile
  9. NOTICE
  10. pom.xml
  11. README.md
README.md

Contributing to Apache Maven Wrapper

ASF Jira Apache License, Version 2.0, January 2004 Maven Central Jenkins Status Jenkins tests

You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a JIRA account.
  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors. There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
[MWRAPPER-XXX] - Subject of the JIRA Ticket
 Optional supplemental description.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.
  • Update your JIRA ticket and include a link to the pull request in the ticket.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Making Trivial Changes

For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.

Additional Resources