Google Git
Sign in
apache/maven-war-plugin/refs/heads/master
commit
c78c4a0fb0e312dfc10f3d5f7b14487ddb45db11
[log]
author
Elliotte Rusty Harold <elharo@users.noreply.github.com>
Tue Jul 28 11:37:15 2026 +0000
committer
GitHub <noreply@github.com>
Tue Jul 28 11:37:15 2026 +0000
tree
02e35b95a6a979d8011da277e9a2432cb01f0779
parent
9ae487c1ec30897c2b9fa26bb1efb0ef7df9626f [diff]
[MWAR-471] normalize file permissions on dependencies copied to WEB-INF/lib (#634)

* MWAR-471: normalize file permissions on dependencies copied to WEB-INF/lib

* Add unit test for file permission normalization in copyFile

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Extract TestWarPackagingContext to fix checkstyle MethodLength violation

* Fix tests on Windows: skip canExecute assertion on platforms without POSIX permissions

* Add canRead and canWrite assertions to permission normalization tests

* Guard canExecute assertions with POSIX permissions capability check

* Simplify Windows guard: use assumeFalse instead of capability probe

* Use Locale.ROOT for toLowerCase and add comment explaining Windows guard

* Fix short-circuit bug in permission normalization; add scope comment

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 files changed
tree: 02e35b95a6a979d8011da277e9a2432cb01f0779
  1. .github/
  2. src/
  3. .asf.yaml
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. deploySite.sh
  8. Jenkinsfile
  9. LICENSE
  10. pom.xml
  11. README.md
README.md

Contributing to Apache Maven WAR Plugin

Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Additional Resources