tree f1bd34b94a4ddba278b70aa7387758ae11587b71
parent 5fbd51eb194f97fb97af8b43d2070da7ce577fe3
author Michael Osipov <michaelo@apache.org> 1535667236 +0200
committer Michael Osipov <michaelo@apache.org> 1535667369 +0200

[WAGON-529] Clean up inconsistent status code and reason phrase handling

* Write a cleaned up message to TransferFailedException
* Drop reason phrase from other exceptions where the message already
contains the phrase
* Renamed the HttpWagonReasonPhraseTest to HttpWagonErrorTest because it
was ill-designed: the test assumed that the message set by
HttpServletResponse#sendError() is returned in the status line to the
client by the server, but this is not true. The Servlet Spec says that
this message (not reason) has to be written to an HTML page. In this
case, Jetty simply wrote that to the status line, but we shall not rely
on an implementation detail of just one server. The spec does not offer
an option to actively set the reason phrase.

The reason phrase is optional after all, don't use it. Use the status
code.