commit 5a393a4baab284fca444fd13c8075bdf30b9b487
author tibordigana <tibordigana@apache.org> Wed Sep 30 15:01:27 2020 +0200
committer tibordigana <tibordigana@apache.org> Wed Sep 30 15:01:27 2020 +0200
tree 46eb7e2a5fb3e839becfbfbc204363096b24c195
parent a56ebdea5d960a736d5c17891572ff33a3fe4c02

removed the unused method parameter LegacyMasterProcessChannelEncoder

surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java

diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java
index f8cb224..dba0f9b 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoder.java
@@ -314,10 +314,9 @@
 
     private void encodeOpcode( ForkedProcessEventType eventType, boolean sendImmediately )
     {
-        CharsetEncoder encoder = DEFAULT_STREAM_ENCODING.newEncoder();
         int bufferMaxLength = estimateBufferLength( eventType, null, null, 0 );
         ByteBuffer result = ByteBuffer.allocate( bufferMaxLength );
-        encodeOpcode( encoder, result, eventType, null );
+        encodeOpcode( result, eventType, null );
         encodeAndPrintEvent( result, sendImmediately );
     }
 
@@ -421,7 +420,7 @@
         encodeString( encoder, result, reportEntry.getNameText() );
         encodeString( encoder, result, reportEntry.getGroup() );
         encodeString( encoder, result, reportEntry.getMessage() );
-        encodeInteger( encoder, result, reportEntry.getElapsed() );
+        encodeInteger( result, reportEntry.getElapsed() );
 
         encode( encoder, result, stackTraceWrapper );
 
@@ -457,7 +456,7 @@
         result.put( (byte) ':' );
     }
 
-    private static void encodeInteger( CharsetEncoder encoder, ByteBuffer result, Integer i )
+    private static void encodeInteger( ByteBuffer result, Integer i )
     {
         if ( i == null )
         {
@@ -473,7 +472,7 @@
     static void encodeHeader( CharsetEncoder encoder, ByteBuffer result, ForkedProcessEventType operation,
                               RunMode runMode )
     {
-        encodeOpcode( encoder, result, operation, runMode );
+        encodeOpcode( result, operation, runMode );
         String charsetName = encoder.charset().name();
         result.put( (byte) charsetName.length() );
         result.put( (byte) ':' );
@@ -488,8 +487,7 @@
      * @param operation opcode
      * @param runMode   run mode
      */
-    static void encodeOpcode( CharsetEncoder encoder, ByteBuffer result, ForkedProcessEventType operation,
-                              RunMode runMode )
+    static void encodeOpcode( ByteBuffer result, ForkedProcessEventType operation, RunMode runMode )
     {
         result.put( (byte) ':' );
         result.put( MAGIC_NUMBER_BYTES );

surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java

diff --git a/surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java b/surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java
index 0262f3e..11f2d16 100644
--- a/surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java
+++ b/surefire-booter/src/test/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelEncoderTest.java
@@ -1007,7 +1007,7 @@
     {
         CharsetEncoder encoder = UTF_8.newEncoder();
         ByteBuffer result = ByteBuffer.allocate( 128 );
-        encodeOpcode( encoder, result, BOOTERCODE_TEST_ERROR, NORMAL_RUN );
+        encodeOpcode( result, BOOTERCODE_TEST_ERROR, NORMAL_RUN );
         assertThat( toString( result ) )
                 .isEqualTo( ":maven-surefire-event:" + (char) 10 + ":test-error:" + (char) 10 + ":normal-run:" );