Google Git
Sign in
apache/maven-shade-plugin/refs/heads/master
commit
db65da2df3feaa9ddfee7f46ab9a646974f499da
[log]
author
Sylwester Lachiewicz <slachiewicz@apache.org>
Mon Aug 10 02:40:57 2026 +0200
committer
Sylwester Lachiewicz <slachiewicz@apache.org>
Mon Aug 10 02:59:50 2026 +0200
tree
95a4c9bae8c2aed02828253b154697947e94d3d6
parent
eb835aff8447fa0cc085728d97fa01e671e43112 [diff]
Use <a id> rather than <a name> for the FAQ anchors

Follow-up to the FML to Markdown conversion.

maven-site-plugin 3.21.0 strips the name= attribute from an inline HTML
anchor; 3.22.0 keeps it. On 3.21.0 every anchor on the page is therefore
lost silently, on a green build. This repo builds with a parent that
pulls 3.22.0, so the pages are correct today, but <a id> is the form
that survives either way - and Xhtml5BaseParser reads Attribute.ID
first, falling back to NAME only if it is absent, so id= is the primary
path. name= on <a> is obsolete in HTML5 besides.

Each anchor stays on its own line; folding one into the heading text
suppresses the section's own generated id.

Verified by rendering faq.html before and after: the anchor set is
unchanged and still a superset of what the original FML page served,
the <head> is byte-identical, the visible text matches the FML original
word for word, and the site log reports no "used more than once"
warning.

Generated-by: Claude Opus 5 (1M context)
1 file changed
tree: 95a4c9bae8c2aed02828253b154697947e94d3d6
  1. .github/
  2. src/
  3. .asf.yaml
  4. .git-blame-ignore-revs
  5. .gitignore
  6. AGENTS.md
  7. Jenkinsfile
  8. LICENSE
  9. pom.xml
  10. README.md
  11. SECURITY.md
README.md

Contributing to Apache Maven Shade Plugin

Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Developer Tips

If your machine is sufficiently powerful, and you want to parallelize the IT execution to validate the build before a PR you can set the concurrency in MAVEN_OPTS:

MAVEN_OPTS=-Dinvoker.parallelThreads=2 mvn verify -Prun-its

You can also run a single IT test using:

mvn verify -Prun-its -Dinvoker.test=myitproject

Additional Resources