commit cf24c1a920adf4b86b51f27f949f71c6b4e4ccbd
author Alexander Kriegisch <Alexander@Kriegisch.name> Sun Apr 04 10:33:20 2021 +0700
committer Hervé Boutemy <herve.boutemy@free.fr> Sat May 22 23:23:58 2021 +0200
tree 0fe555149e7cab7638e4cc37d7adbdb79533aeb0
parent 02fba3ab6712092076b9071b4c411826c7ebd53d

[MSHADE-252] Make relocation ex-/include matching more lenient, accepting '.**' too

Actually, class patterns are supposed to should just use 'foo.bar.*'
ending with a single asterisk, but some users mistake them for path
patterns like 'my/path/**', so let us be a bit more lenient here.

See also my related comment in MSHADE-252:
https://issues.apache.org/jira/browse/MSHADE-252?focusedCommentId=17314393&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17314393

src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java

diff --git a/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java b/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
index 48be8f8..34f48b6 100644
--- a/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
+++ b/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
@@ -114,15 +114,13 @@
         if ( patterns != null && !patterns.isEmpty() )
         {
             normalized = new LinkedHashSet<>();
-
             for ( String pattern : patterns )
             {
-
                 String classPattern = pattern.replace( '.', '/' );
-
                 normalized.add( classPattern );
-
-                if ( classPattern.endsWith( "/*" ) )
+                // Actually, class patterns should just use 'foo.bar.*' ending with a single asterisk, but some users
+                // mistake them for path patterns like 'my/path/**', so let us be a bit more lenient here.
+                if ( classPattern.endsWith( "/*" ) || classPattern.endsWith( "/**" ) )
                 {
                     String packagePattern = classPattern.substring( 0, classPattern.lastIndexOf( '/' ) );
                     normalized.add( packagePattern );