commit | 1dca37c71649fa4f4aa110de3b78cc98d0e47eda | [log] [tgz] |
---|---|---|
author | Alexander Kriegisch <Alexander@Kriegisch.name> | Mon Jul 12 14:44:53 2021 +0700 |
committer | Romain Manni-Bucau <rmannibucau@gmail.com> | Mon Aug 16 12:46:54 2021 +0200 |
tree | e4391324016bc2ef83feeab1c05ed456a56c68c2 | |
parent | c13c9bb1afeb9c6be8ca900c2bd0bb8cbdd2af3c [diff] |
[MSHADE-396] Improve SourceContent Shading Improve search & replace heuristics without destroying previously correct replacements in my test project (AspectJ). This solution is still bound to fail in some situations, simply because it is just a heuristic approach and not a full Java parser correctly recognising package names in all possible situations in Java source code. As for matching within Java string constants, this is next to impossible to get 100% right. But the source shading feature is not meant as a source code generator anyway, merely as a tool creating reasonably plausible source code when navigating to a relocated library class from an IDE, hopefully displaying source code which makes 95% sense - no more, no less.
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MSHADE-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.
If you machine is big enough and you want to parallelise the IT execution to validate the build before a PR you can set the concurrency in MAVEN_OPTS:
MAVEN_OPTS=-Dinvoker.parallelThreads=2 mvn verify -Prun-its
You can also run a single IT test using:
mvn verify -Prun-its -Dinvoker.test=myitproject