commit | 02fba3ab6712092076b9071b4c411826c7ebd53d | [log] [tgz] |
---|---|---|
author | Tamas Cservenak <tamas@cservenak.net> | Fri May 21 10:38:15 2021 +0200 |
committer | Tamas Cservenak <tamas@cservenak.net> | Fri May 21 10:38:15 2021 +0200 |
tree | 96210d57703011d6ad4816597b89b3f0101182f8 | |
parent | e6902dd34a917014864162ca05d06fee14f4e4c5 [diff] |
Fix for Java16+ The commit fa5e40dc59355163d89cd904fcf4c4724ba3d3d6 made build fail on Java16 due illegal reflective access. The commit is wrong that is uses "aop" guice, that is the culprit of illegal reflective access (on Java11 generates a warning on system out, but Java16 prevents it). Solution: use the "no_aop" guice instead. Also, there was a SLF4J warning about non existence of backend in tests, fixed by adding simple backend with test scope.
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MSHADE-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.
If you machine is big enough and you want to parallelise the IT execution to validate the build before a PR you can set the concurrency in MAVEN_OPTS:
MAVEN_OPTS=-Dinvoker.parallelThreads=2 mvn verify -Prun-its
You can also run a single IT test using:
mvn verify -Prun-its -Dinvoker.test=myitproject