commit | 5a7875e78a1d78fd1309c6cd9c40c6a740d6a932 | [log] [tgz] |
---|---|---|
author | Tim te Beek <tim@moderne.io> | Tue May 09 20:06:57 2023 +0200 |
committer | GitHub <noreply@github.com> | Tue May 09 14:06:57 2023 -0400 |
tree | 40b5e52c710defa2327dfa3294132bb08e0001e1 | |
parent | cbdee3b191bf10c839c280d31b09741aaeadaa8d [diff] |
[MNG-6829] refactor: Replace any StringUtils#isEmpty(String) and #isNotEmpty(String) (#169) * [MNG-6829] refactor: Replace any StringUtils#isEmpty(String) and #isNotEmpty(String) ### [Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)](https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk) A continuation of https://issues.apache.org/jira/browse/MNG-6825 and https://issues.apache.org/jira/browse/MNG-6829, where previously a request was made to instead of switching implementation to a different StringUtils, we should instead switch to using JDK internals where we can. This is a first such pull request to gauge interest before I can potentially make 47 more PRs to replace a total of 210 uses of isEmpty / isNotEmpty. Co-authored-by: Moderne <team@moderne.io> * Apply Spotless --------- Co-authored-by: Moderne <team@moderne.io>
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[SCM-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.