Google Git
Sign in
apache / maven-resolver / 5b03ce5efd1fa7947ef9bfdffb740ce9d49da2a3
commit5b03ce5efd1fa7947ef9bfdffb740ce9d49da2a3[log] [tgz]
authorTamas Cservenak <tamas@cservenak.net>Thu Nov 14 14:26:02 2024 +0100
committerGitHub <noreply@github.com>Thu Nov 14 14:26:02 2024 +0100
treeed6d50dde247294c5104f7dc43f35d9c69e2921d
parentc32b8c9236389ee04ab5d0aac3d206f8bb1b2f36 [diff]
[MRESOLVER-627] Improve transport selection and logging (#599)

In previous releases transport selection was really secretive and broken, as it considered invalid configuration as "protocol not supported" and Resolver did not log anything or worse, silently skipped to new transport.

Changes:
* transport provider: was logging ONLY if transport selection failed (no transport was selected), changed to continuously log (in DEBUG) why a transport was ignored and next selection performed. Also, in case of total failure, exceptions are added now as suppressed ones instead just lost.
* multiple transporter factories: smaller fixes for earlier protocol detection (file is exception to support cases like JIMFS), and when client creation is attempted but it fails due runtime exception, fail the whole process (like bad enum in JDK transport config).
* before all transporter "blanket" threw NoTransporterEx and Basic connector was "protecting" caller from it, hence to continue doing so, no basic connector "blankets" all runtime and non-runtime exceptions coming from transport to "early report" problem as it happens in basic connector ctor.

---

https://issues.apache.org/jira/browse/MRESOLVER-627
17 files changed
tree: ed6d50dde247294c5104f7dc43f35d9c69e2921d
  1. .github/
  2. maven-resolver-api/
  3. maven-resolver-connector-basic/
  4. maven-resolver-demos/
  5. maven-resolver-generator-gnupg/
  6. maven-resolver-generator-sigstore/
  7. maven-resolver-impl/
  8. maven-resolver-named-locks/
  9. maven-resolver-named-locks-hazelcast/
  10. maven-resolver-named-locks-ipc/
  11. maven-resolver-named-locks-redisson/
  12. maven-resolver-spi/
  13. maven-resolver-supplier-mvn3/
  14. maven-resolver-supplier-mvn4/
  15. maven-resolver-test-http/
  16. maven-resolver-test-util/
  17. maven-resolver-tools/
  18. maven-resolver-transport-apache/
  19. maven-resolver-transport-classpath/
  20. maven-resolver-transport-file/
  21. maven-resolver-transport-jdk-parent/
  22. maven-resolver-transport-jetty/
  23. maven-resolver-transport-minio/
  24. maven-resolver-transport-wagon/
  25. maven-resolver-util/
  26. src/
  27. .asf.yaml
  28. .git-blame-ignore-revs
  29. .gitignore
  30. class-overview.svg
  31. Jenkinsfile
  32. LICENSE
  33. pom.xml
  34. README.md
README.md

Contributing to Apache Maven Artifact Resolver

ASF Jira Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a JIRA account.
  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors. There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
[MRESOLVER-XXX] - Subject of the JIRA Ticket
 Optional supplemental description.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.
  • Update your JIRA ticket and include a link to the pull request in the ticket.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Making Trivial Changes

For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.

Additional Resources