Google Git
Sign in
apache / maven-resolver / 08f102a4579a911afff8a8301cb1a708c3bc26af
commit08f102a4579a911afff8a8301cb1a708c3bc26af[log] [tgz]
authorTamas Cservenak <tamas@cservenak.net>Mon Dec 11 10:19:29 2023 +0100
committerGitHub <noreply@github.com>Mon Dec 11 10:19:29 2023 +0100
tree3e2a7b921b1e5931e7edb970518f5bf92f3ad962
parent5e2ae014581bcaf75710e0794badf5b7001cbf28 [diff]
[MRESOLVER-449] Step toward testing all HTTP transports (#391)

Right now, the HTTP test suite is pulled out and reused for all HTTP transports. It passes for ApacheTransporter (as it was pulled from it), but Jetty and JDK show some signs of some problems...

Current results (note: base class HttpTransporterTest has 70 tests, while some transport specific UTs add more):
* apache :heavy_check_mark: 74 test OK
* jdk :red_circle: 62 test OK, 9 test FAIL
* jetty :red_circle: 64 test OK, 6 FAIL

The "basics" are overall good (basics pass everywhere), failures stems from small differences.

Jetty: it seems it consumes the body (pulls bytes out of it) even before all the HTTP auth happens, this causes that `TransportListener` gets notified "transport started" but in fact is not and test asserts it to not. Also, Jetty throws in tests where server is set up to abruptly close the connection. Retries are not properly done (low level, like abrupt connection drop).

JDK: same problem with body (pulls bytes beforehand) and similarly as with Jetty, "transport started" events fails the test. Preemptive auth is not done (as it seems it is either "manual" handling of auth or Authenticator is used but then preemptive auth becomes impossible as headers are removed, no way to set them). It also throws in tests where server abruptly drops connection. Same for retries (in case of TCP issue).

---

https://issues.apache.org/jira/browse/MRESOLVER-449
31 files changed
tree: 3e2a7b921b1e5931e7edb970518f5bf92f3ad962
  1. .github/
  2. maven-resolver-api/
  3. maven-resolver-connector-basic/
  4. maven-resolver-demos/
  5. maven-resolver-impl/
  6. maven-resolver-named-locks/
  7. maven-resolver-named-locks-hazelcast/
  8. maven-resolver-named-locks-redisson/
  9. maven-resolver-spi/
  10. maven-resolver-supplier/
  11. maven-resolver-test-http/
  12. maven-resolver-test-util/
  13. maven-resolver-tools/
  14. maven-resolver-transport-apache/
  15. maven-resolver-transport-classpath/
  16. maven-resolver-transport-file/
  17. maven-resolver-transport-jdk-parent/
  18. maven-resolver-transport-jetty/
  19. maven-resolver-transport-wagon/
  20. maven-resolver-util/
  21. src/
  22. .asf.yaml
  23. .git-blame-ignore-revs
  24. .gitignore
  25. class-overview.svg
  26. Jenkinsfile
  27. LICENSE
  28. pom.xml
  29. README.md
README.md

Contributing to Apache Maven Artifact Resolver

ASF Jira Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a JIRA account.
  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors. There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
[MRESOLVER-XXX] - Subject of the JIRA Ticket
 Optional supplemental description.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.
  • Update your JIRA ticket and include a link to the pull request in the ticket.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Making Trivial Changes

For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.

Additional Resources