Google Git
Sign in
apache/maven-release/refs/heads/master
commit
1372a681f33d861fa8908b11e1d17f9086ab2556
[log]
author
Guillaume Nodet <gnodet@gmail.com>
Tue May 19 21:28:11 2026 +0200
committer
GitHub <noreply@github.com>
Tue May 19 21:28:11 2026 +0200
tree
88532c4cd744d6ddcb8caeaf6b1a0e5e1a4ddf97
parent
f32f6221eca8b3e49d1d3a4509a18a6c5a4fc757 [diff]
Replace JDOM2 with DomTrip for lossless POM XML editing (#1466)

* Replace JDOM2 with DomTrip for lossless POM XML editing

DomTrip provides lossless XML round-tripping, preserving comments,
whitespace, attribute order, quote styles, CDATA sections, and entity
encoding. This eliminates the intro/outtro hacks required by JDOM2.

- Replace `org.jdom:jdom2` with `eu.maveniverse.maven.domtrip:domtrip-core:1.1.0`
- Implement 16 DomTrip wrapper classes mirroring the previous JDOM2 wrappers
- Delete all JDOM2 source (18 files) and test (8 files) classes
- Switch default ModelETL from `jdom2` to `domtrip`
- Add 8 new unit test classes (147 tests) covering all DomTrip wrappers
- Add formatting preservation IT with byte-for-byte comparison
- Fix `DomTripProperties.put()` to return previous value per `Hashtable.put` contract

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Bump domtrip-core from 1.1.0 to 1.4.0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix spotless formatting violations in DomTrip test files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
51 files changed
tree: 88532c4cd744d6ddcb8caeaf6b1a0e5e1a4ddf97
  1. .github/
  2. maven-release-api/
  3. maven-release-manager/
  4. maven-release-plugin/
  5. maven-release-policies/
  6. src/
  7. .asf.yaml
  8. .gitignore
  9. deploySite.bat
  10. deploySite.sh
  11. Jenkinsfile
  12. LICENSE
  13. pom.xml
  14. README.md
README.md

Contributing to Apache Maven Release (Plugin)

Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Additional Resources