commit | 099694245605cb6095f361488829bed50bf0f1e5 | [log] [tgz] |
---|---|---|
author | Benjamin Marwell <bmarwell@apache.org> | Sun Mar 03 22:19:06 2024 +0100 |
committer | GitHub <noreply@github.com> | Sun Mar 03 22:19:06 2024 +0100 |
tree | 9b768df214d7a3322731975d15fc7042212d5771 | |
parent | 928458276d9b9e922fe7128470f1ad4a3a1003be [diff] |
[MJMOD-32] remove dependency to commons-lang3 (#22)
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MJMOD-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.
If you are running your Maven installation with a different JDK than JDK 9 you have give the JDK 9 path via the command line:
mvn clean verify -Prun-its -Dinvoker.javaHome=JDK9JAVAHOME
The reason behind this is simply cause Maven JMod Plugin will call jmod
tool of the JDK which is needed to be found. Otherwise none of the integration tests can work.