Add PATH fallback when JAVA_HOME is unset (#72)

* Add PATH fallback when JAVA_HOME is unset

- Modified AbstractJDepsMojo.getJDepsExecutable() to search for jdeps in PATH when JAVA_HOME is not set or jdeps is not found in JAVA_HOME
- Changed JAVA_HOME from required to optional
- Improved error message to inform users about both JAVA_HOME and PATH options
- Added integration test to verify PATH fallback functionality works correctly

This change allows the plugin to work in environments where JAVA_HOME is not set,
as long as jdeps is available in the system PATH, which is common in many
development environments and CI/CD systems.

Fixes: Support for running jdeps when JAVA_HOME is not configured

* Update src/main/java/org/apache/maven/plugins/jdeps/AbstractJDepsMojo.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/main/java/org/apache/maven/plugins/jdeps/AbstractJDepsMojo.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Resolve PR review comments: improve PATH lookup and integration test

- Reuse env Properties object to avoid duplicate retrieval
- Use canonical paths consistently for both JAVA_HOME and PATH lookups
- Add check to skip empty PATH entries
- Add canExecute() verification for executable permissions
- Improve error message to be more generic
- Unset JAVA_HOME in integration test to properly test PATH fallback

* Update src/main/java/org/apache/maven/plugins/jdeps/AbstractJDepsMojo.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/main/java/org/apache/maven/plugins/jdeps/AbstractJDepsMojo.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: GitHub Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
5 files changed
tree: 7fe181da2155261544f9f580821175b24c17e90f
  1. .github/
  2. src/
  3. .asf.yaml
  4. .gitignore
  5. Jenkinsfile
  6. LICENSE
  7. pom.xml
  8. README.md
README.md

Contributing to Apache Maven JDeps Plugin

Apache License, Version 2.0, January 2004 Maven Central Jenkins Status Jenkins tests

You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Additional Resources