|author||fwienber <firstname.lastname@example.org>||Wed Nov 20 13:21:30 2019 +0100|
|committer||fwienber <email@example.com>||Wed Nov 20 13:21:30 2019 +0100|
[MJAVADOC-620] Integration test for JAR with version without dots The second case in which the module info retrieval fails is a JAR with a file name that contains a number *not* followed by a dot. This is the case we experienced, because we often use 1-SNAPSHOT as the working version, resulting in a JAR file name like "foo-1-SNAPSHOT.jar". The FindException has a root cause that says that the module name derived from the file name, "foo.1.SNAPSHOT", is invalid because "1" is not a valid Java identifier. Compared to the first integration test, the version number of the test project has been changed from "1.0" to just "1". To test one failure cause at a time, the test class Test has been moved from the top-level package into package "somepackage". Without the fix, maven-MJAVADOC620-jar-1-SNAPSHOT.jar is not added to the classpath and building the JavaDoc fails, because class Test is not found. With the fix, maven-MJAVADOC620-jar-1-SNAPSHOT.jar is added to the classpath and building the JavaDoc succeeds.
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
Some of the ideas are documented in the Maven Wiki which might be interesting to read and for further discussion.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --checkbefore committing.
[MJAVADOC-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verifyto assure nothing else was accidentally broken.
If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.