commit | d39b2755b3c94318e38fb69cd156f9d3f701a15d | [log] [tgz] |
---|---|---|
author | Reto Weiss <reto.weiss@ivyteam.ch> | Wed Apr 08 12:24:04 2020 +0200 |
committer | GitHub <noreply@github.com> | Wed Apr 08 06:24:04 2020 -0400 |
tree | 32947441a891735f65d5acbc8f3275e3294406cb | |
parent | e203bbf08ff1944800538fb6101e181b70b56553 [diff] |
[MJAVADOC-617] Normalize module path so that '..' in the path are resolved (#27) * MJAVADOC-617 Normalize module path so that '..' in the path are resolved On line 2403 a path is removed from a map. The given path may not be normalized but the pathes in the map are. This leads to the fact that the project for the given path is not found. And therefore no javadoc for the project is generated. By normalizing the module path on line 2396 the code works event if the module path has '..' in it. * MJAVADOC-617 Add regression test * MJAVADOC-617 Simplify code as suggested by review * MJAVADOC-617 Fix checkstyle problems * MJAVADOC-617 Refactor duplicated code into abstract sub classes - Refactor duplicated code into common new AbstractAggregateMavenProjectStub and AbstractAggregateChildMavenProjectStub classes - Fix toLowerCase without Locale - Simplify method getOverviewSummary and make it static * MJAVADOC-617 improve test assertions
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
Some of the ideas are documented in the Maven Wiki which might be interesting to read and for further discussion.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MJAVADOC-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.