commit | 0799b53b804d75ddee1ad2254e62a05199b416c5 | [log] [tgz] |
---|---|---|
author | Michael Osipov <michaelo@apache.org> | Sun Feb 17 13:31:38 2019 +0100 |
committer | Michael Osipov <michaelo@apache.org> | Thu Feb 28 08:31:33 2019 +0100 |
tree | 18fbb14a6193cb8cf4249a7e14759f2e934c2e32 | |
parent | fd0c42a5426e2c6a97fd866548fbaba39106a13f [diff] |
[MJAVADOC-565] Make proxy configuration properly work for both HTTP and HTTPS Javadoc uses URLConnection to retrieve external resources, thus one has to configure proxies for HTTP *and* for HTTPS. Apply the following logic to set proxies properly: * Iterate over all proxies and collect active (first) ones for HTTP and HTTPS * If HTTPS is availabe, use it for HTTPS as well as for non proxy hosts, but if and only if proxy for HTTP is not available * Else use HTTP proxy for both HTTP and HTTPS if HTTPS hasn't been set Additionally, *.proxyUser and *.proxyPassword have been removed. These properties aren't read by Java's URLConnection. This feature exists in Apache HttpClient only. This closes #17
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
Some of the ideas are documented in the Maven Wiki which might be interesting to read and for further discussion.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MJAVADOC-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.