commit | b59d531921cbbbf3ee280ccfcec3657525d8fe26 | [log] [tgz] |
---|---|---|
author | Christian Stein <sormuras@gmail.com> | Fri Nov 16 13:12:56 2018 +0100 |
committer | Christian Stein <sormuras@gmail.com> | Sat Dec 01 16:42:50 2018 +0100 |
tree | 3ee4dcf42bf2bc48afc4320864b2281a9755e812 | |
parent | 58a570ad7d16767cd47181eefe304f2e83dc88b6 [diff] |
[MJAR-260] Upgrade to Archiver 3.3.0 and add ITs This PR updates the dependency to the version `3.3.0` of the Maven Archiver and introduces two integration tests that a) verify that JAR containing a valid name is created and b) that no JAR file is created when it would contain an invalid automatic module name. Addresses https://issues.apache.org/jira/browse/MJAR-260
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MJAR-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.