tree 254ca00a737d19b21624e24882a330a4f6e7d941
parent 9fa9fd5298023746eae807a20ca90e972a4ef34d
author Tamas Cservenak <tamas@cservenak.net> 1657631467 +0200
committer GitHub <noreply@github.com> 1657631467 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJizXLrCRBK7hj4Ov3rIwAABzwIAGTS9FFjSOS85/f3GLD6BmpZ
 MwMmqSUjIShsMMA0GSJAe80JQYqwy+UAIJvnmjT6WCwmnCcatNNL9PzbCHZO2O+C
 3oWc29dgDbNqqzlzUYSKN7WjDqw48QylZO1krzuefjsKsh08AzEWCUEVnObODgrS
 rMtgEGeF0f8OljytylnJXhpGWxOd6/+vMI61ChK6Rph7HVOY7HSJpZ04f5jFXyS5
 LM2wmrlYxBl2Ski8cKhUbUUHUNYFAXnviJTfoF9iyf/0othXcPFfXUNm6kOadtpJ
 UBBxICEdW4+cJ8TzM3vaGvybWfgmP/5kJHM5zuei/PH8l9imcG7JskecUI6nHz4=
 =G1Jp
 -----END PGP SIGNATURE-----
 

[MINSTALL-177] Streamline the plugin (#32)

Original plugin made hoops and loops, instead to perform what it needed to perform. Partly to blame this was unfinished state of MAT API (it was able to install project only).

Installing project is needed in InstallMojo, but InstallFileMojo was forced to make hoops and loops due this, as it was passed one file (and maybe pomFile), and it was forced to create "fake" project, decorate and fake setup it with all whistle and bells, only to get it via MAT to resolver that would "decompose" it back into set of artifacts needing a deploy. So it went this file-artifact-project-artifact route, that made all the logic fragile and overly complicated.

This PR completely reworks m-install-p making it (almost trivially) simple: it does what it needs to do, without any fuss, and does it in streamlined way: InstallMojo will create a list of artifacts out of project and pass it to repository system for deploy, while InstallFileMojo literally prepares just a deployment request,  nothing more. No fuss, no magic, no fake project building etc.

Note: the code in mojos may or may not need to be reusable, but definitely smells like some "Maven API-ish thing". 

Problems: InstallFileMojo implicitly implemented ID validation (thru fake project building), and it revealed the problem that Maven ID (groupId, artifactId) and version validation is deeply buried into maven-model-builder and is NOT reusable at all, hence a light copy of logic (rules for ID allowed characters and version forbidden characters) are copied over here.