Google Git Google Git
Sign in
apache/maven-help-plugin/refs/heads/master
commit
57b496fe7e9fa4027434b183b92fd941087ae3ea
[log]
author
Arturo Bernal <abernal@apache.org>
Thu Oct 29 14:20:01 2026 +0100
committer
Slawomir Jaranowski <s.jaranowski@gmail.com>
Mon Nov 09 23:22:07 2026 +0100
tree
679f54691046274c72b5e9489459b7a199adfa72
parent
f3cd0339e618453ec4d8ceb6fc65dedb3548720f [diff] 
Fix #326: resolve a described plugin against plugin repositories

AbstractHelpMojo.resolveArtifact() always resolved against
project.getRemoteProjectRepositories(). DescribeMojo calls it to
resolve a plugin's own jar/pom in two places: the fallback name
lookup when a plugin descriptor has no name, and isReportGoal()'s
check for whether a goal implements MavenReport. Both are resolving
the plugin itself, so a plugin published only to a <pluginRepository>
and not also declared as a project <repository> failed to resolve
there even though Maven resolved and ran the plugin fine during a
normal build.

Added a resolveArtifact(artifact, repositories) overload taking an
explicit repository list, with the existing resolveArtifact(artifact)
delegating to it with project repositories unchanged for its other
callers (getMavenProject, EvaluateMojo). DescribeMojo's three
plugin-resolution call sites now pass
project.getRemotePluginRepositories().
4 files changed
tree: 679f54691046274c72b5e9489459b7a199adfa72
  1. .github/
  2. src/
  3. .asf.yaml
  4. .git-blame-ignore-revs
  5. .gitignore
  6. Jenkinsfile
  7. LICENSE
  8. pom.xml
  9. README.md
README.md

Contributing to Apache Maven Help Plugin

Apache License, Version 2.0, January 2004 Maven Central Reproducible Builds Jenkins Status Jenkins tests

You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Getting Started

  • Make sure you have a GitHub account.
  • If you‘re planning to implement a new feature, it makes sense to discuss your changes on the dev list first. This way you can make sure you’re not wasting your time on something that isn‘t considered to be in Apache Maven’s scope.
  • Submit a ticket for your issue, assuming one does not already exist.
    • Clearly describe the issue, including steps to reproduce when it is a bug.
    • Make sure you fill in the earliest version that you know has the issue.
  • Fork the repository on GitHub.

Making and Submitting Changes

We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:

  • Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository.
  • Make commits of logical units.
  • Respect the original code style: by using the same codestyle, patches should only highlight the actual difference, not being disturbed by any formatting issues:
    • Only use spaces for indentation.
    • Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change.
    • Check for unnecessary whitespace with git diff --check before committing.
  • Make sure you have added the necessary tests (JUnit/IT) for your changes.
  • Run all the tests with mvn -Prun-its verify to assure nothing else was accidentally broken.
  • Submit a pull request to the repository in the Apache organization.

If you plan to contribute on a regular basis, please consider filing a contributor license agreement.

Additional Resources